-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(v2): Replace ioutl.Discard with io.Discard #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughReplaces Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks 🙏 Please could you add an entry to the changelog located at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @website/src/pages/changelog.mdx:
- Line 26: Fix the typo in the changelog entry by replacing "ioutl.Discard" with
the correct symbol "ioutil.Discard"; update the text that currently references
ioutl.Discard (from the PR note by @xjh22222228) so it correctly mentions the
deprecated Go package io/ioutil and uses "ioutil.Discard".
| - Fixed link to CoC in Community Guide when there was a trailing slash by @agilgur5 in [#4732](https://github.com/wailsapp/wails/pull/4732) | ||
| - Fixed indentation in "How does it work?" page by @agilgur5 in [#4733](https://github.com/wailsapp/wails/pull/4733) | ||
| - Updated wails installation documentation to allow copying the `install wails` command with one click by @tilak999 in [#4692](https://github.com/wailsapp/wails/pull/4692) | ||
| - Remove ioutl.Discard and replace it with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo: "ioutl" should be "ioutil".
The deprecated Go package is io/ioutil, so the changelog entry should reference ioutil.Discard (with an 'i'), not ioutl.Discard.
📝 Suggested fix
-- Remove ioutl.Discard and replace it with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)
+- Replace deprecated ioutil.Discard with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - Remove ioutl.Discard and replace it with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877) | |
| - Replace deprecated ioutil.Discard with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877) |
🤖 Prompt for AI Agents
In @website/src/pages/changelog.mdx at line 26, Fix the typo in the changelog
entry by replacing "ioutl.Discard" with the correct symbol "ioutil.Discard";
update the text that currently references ioutl.Discard (from the PR note by
@xjh22222228) so it correctly mentions the deprecated Go package io/ioutil and
uses "ioutil.Discard".
|
|
Thanks! |



Description
Remove ioutl.Discard and replace it with io.Discard.
Fixes # (issue)
Type of change
Please select the option that is relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using
wails doctor.If you checked Linux, please specify the distro and version.
Test Configuration
Please paste the output of
wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.Checklist:
website/src/pages/changelog.mdxwith details of this PRSummary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.