Skip to content

Conversation

@xjh22222228
Copy link
Contributor

@xjh22222228 xjh22222228 commented Jan 13, 2026

Description

Remove ioutl.Discard and replace it with io.Discard.

Fixes # (issue)

Type of change

Please select the option that is relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

If you checked Linux, please specify the distro and version.

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Chores

    • Aligned internal implementation with current Go standard library conventions by updating discard handling.
  • Documentation

    • Added changelog entry noting the discard update in the Unreleased Fixed section.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 13, 2026

📝 Walkthrough

Walkthrough

Replaces ioutil.Discard with io.Discard in source, removes the now-unused ioutil import, and updates the changelog entry. No behavioral or API changes.

Changes

Cohort / File(s) Summary
Source code
v2/internal/s/s.go
Replaced ioutil.Discard with io.Discard in mute() and removed the ioutil import.
Changelog
website/src/pages/changelog.mdx
Updated changelog entry to reference io.Discard instead of ioutil.Discard.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 ioutil tiptoed out of sight,
io.Discard hops in light,
A tiny change, a tidy scene,
Clean imports and code pristine,
Hop on, the rabbit says: keep it bright!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: replacing ioutl.Discard with io.Discard, which aligns directly with the changeset modifications.
Description check ✅ Passed The description follows the template structure with a clear summary, correct type of change selection (bug fix), testing platform indication (macOS), and checklist items completed including changelog update.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at website/src/pages/changelog.mdx?

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @website/src/pages/changelog.mdx:
- Line 26: Fix the typo in the changelog entry by replacing "ioutl.Discard" with
the correct symbol "ioutil.Discard"; update the text that currently references
ioutl.Discard (from the PR note by @xjh22222228) so it correctly mentions the
deprecated Go package io/ioutil and uses "ioutil.Discard".
📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73e04a6 and 222a68e.

📒 Files selected for processing (1)
  • website/src/pages/changelog.mdx

- Fixed link to CoC in Community Guide when there was a trailing slash by @agilgur5 in [#4732](https://github.com/wailsapp/wails/pull/4732)
- Fixed indentation in "How does it work?" page by @agilgur5 in [#4733](https://github.com/wailsapp/wails/pull/4733)
- Updated wails installation documentation to allow copying the `install wails` command with one click by @tilak999 in [#4692](https://github.com/wailsapp/wails/pull/4692)
- Remove ioutl.Discard and replace it with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix typo: "ioutl" should be "ioutil".

The deprecated Go package is io/ioutil, so the changelog entry should reference ioutil.Discard (with an 'i'), not ioutl.Discard.

📝 Suggested fix
-- Remove ioutl.Discard and replace it with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)
+- Replace deprecated ioutil.Discard with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Remove ioutl.Discard and replace it with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)
- Replace deprecated ioutil.Discard with io.Discard by @xjh22222228 in [#4877](https://github.com/wailsapp/wails/pull/4877)
🤖 Prompt for AI Agents
In @website/src/pages/changelog.mdx at line 26, Fix the typo in the changelog
entry by replacing "ioutl.Discard" with the correct symbol "ioutil.Discard";
update the text that currently references ioutl.Discard (from the PR note by
@xjh22222228) so it correctly mentions the deprecated Go package io/ioutil and
uses "ioutil.Discard".

@leaanthony leaanthony enabled auto-merge (squash) January 18, 2026 11:31
@sonarqubecloud
Copy link

@leaanthony leaanthony disabled auto-merge January 20, 2026 00:13
@leaanthony
Copy link
Member

Thanks!

@leaanthony leaanthony merged commit 158fd41 into wailsapp:master Jan 20, 2026
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants