fix(v2): escape XML special characters in macOS plist generation#5175
Draft
leaanthony wants to merge 3 commits intomasterfrom
Draft
fix(v2): escape XML special characters in macOS plist generation#5175leaanthony wants to merge 3 commits intomasterfrom
leaanthony wants to merge 3 commits intomasterfrom
Conversation
Use html/template instead of text/template when processing plist templates so that characters like &, <, > are properly escaped in the generated Info.plist output. Fixes #4865
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
wails.jsoncontains special characters like&in fields such asinfo.copyright, the generatedInfo.plistbecomes invalid XML, breaking macOS packaging (broken app icon, launch failures).The root cause is that
resolveProjectData()inbuildassets.gousestext/template, which performs no escaping. Switching tohtml/templateensures&,<,>,"are properly escaped in the plist output.Before:
"Joe & Bill, Inc."→"Joe & Bill, Inc."(invalid XML)After:
"Joe & Bill, Inc."→"Joe & Bill, Inc."(valid XML)Fixes #4865