fix(linux): fix race conditions and deadlocks in event handling#5192
Draft
leaanthony wants to merge 1 commit intomasterfrom
Draft
fix(linux): fix race conditions and deadlocks in event handling#5192leaanthony wants to merge 1 commit intomasterfrom
leaanthony wants to merge 1 commit intomasterfrom
Conversation
…ling (#4424) This commit addresses issues that could cause menu buttons to stop responding when events are being emitted frequently: 1. Fixed race condition in mainthread callback store (Linux, macOS, iOS): - Changed RLock() to Lock() when deleting from mainThreadFunctionStore - Using RLock for read-only operations but then calling delete() violated the RWMutex contract and could cause undefined behavior 2. Fixed potential deadlock in EventIPCTransport.DispatchWailsEvent: - Changed to snapshot windows list and release lock before dispatching - Previously held windowsLock.RLock() during ExecJS which blocks waiting for the main thread, potentially causing deadlocks if main thread operations needed windowsLock.Lock() 3. Added test case to reproduce the issue 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> # Conflicts: # v3/UNRELEASED_CHANGELOG.md
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RLockused for map deletion inmainthread_linux.go,mainthread_darwin.go, andmainthread_ios.go— map writes underRLockcause undefined behavior with concurrent readersDispatchWailsEventholdingwindowsLockduring potentially blockingExecJSdispatch — release lock before dispatching to prevent deadlocks when the main thread also needs the lockFatalin nil callback path to avoid lock leakFixes #4424
Test plan
TestMainThreadFunctionStoreLockCorrectness— concurrent callback store access with Lock (not RLock)TestMainThreadFunctionStoreConcurrentReadWrite— concurrent readers and writersTestDispatchWailsEventReleasesLockAfterCompletion— lock is released after dispatchv3/test/4424-event-block/main.go— manual test with event emitter + menu clicks