fix(windows): support custom dialog button callbacks via TaskDialog API#5193
Draft
leaanthony wants to merge 1 commit intomasterfrom
Draft
fix(windows): support custom dialog button callbacks via TaskDialog API#5193leaanthony wants to merge 1 commit intomasterfrom
leaanthony wants to merge 1 commit intomasterfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Windows dialogs with custom buttons and OnClick callbacks were silently ignored because MessageBox only supports predefined button sets (OK, Yes, No, etc.). Users could add buttons with custom labels but callbacks never fired. Use TaskDialogIndirect (comctl32.dll, Vista+) when custom buttons are present, which supports arbitrary button labels and proper callback dispatch by button ID. Falls back to the existing MessageBox path when no custom buttons are defined. Fixes #4402
631071c to
21683cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskDialogIndirectfromcomctl32.dll) for dialogs with custom buttons, enablingAddButtonandSetDefaultButtoncallbacks to actually fire on WindowsThe root cause was that Windows
MessageBoxAPI only supports a fixed set of predefined buttons (OK, Cancel, Yes, No). Custom button labels like "Quit" were never matched against the predefined responses, so callbacks never fired. The TaskDialog API (available since Vista) supports arbitrary button labels.Fixes #4402
Test plan
TestWindowsDialogButtonCallbacks— OK button, case-insensitive matching, multiple buttons, whitespace handlingTestDialogButtonTypes— Info, Error, Warning, Question dialog typesTestCustomButtonLabels— custom labels, emoji/Unicode, default/cancel flagstests/windows_dialog_callback_example.goNote: Runtime tests require Windows. The unit tests verify callback wiring without showing dialogs.