Skip to content

fix(v3/examples): update go.sum files for Windows webview2 dependency#5400

Merged
leaanthony merged 4 commits into
wailsapp:masterfrom
taliesin-ai:agent/engineer-windows/85f03056
May 11, 2026
Merged

fix(v3/examples): update go.sum files for Windows webview2 dependency#5400
leaanthony merged 4 commits into
wailsapp:masterfrom
taliesin-ai:agent/engineer-windows/85f03056

Conversation

@taliesin-ai
Copy link
Copy Markdown
Collaborator

@taliesin-ai taliesin-ai commented May 11, 2026

Summary

Six examples had go.sum files generated on Linux/macOS that were missing the Windows-only github.com/wailsapp/wails/webview2 dependency. On Windows, go build . failed with:

missing go.sum entry for module providing package github.com/wailsapp/wails/webview2/pkg/edge

Affected examples: dev, file-association, gin-routing, gin-service, notifications, server

Fix: Ran go mod tidy on Windows in each affected example directory to add the missing webview2 entry to go.sum.

Changes

  • v3/examples/dev/go.sum — add github.com/wailsapp/wails/webview2 v1.0.24
  • v3/examples/file-association/go.sum — add github.com/wailsapp/wails/webview2 v1.0.24
  • v3/examples/gin-routing/go.sum — add github.com/wailsapp/wails/webview2 v1.0.24
  • v3/examples/gin-service/go.mod + go.sum — add github.com/wailsapp/wails/webview2 v1.0.24 and github.com/coder/websocket v1.8.14
  • v3/examples/notifications/go.sum — add github.com/wailsapp/wails/webview2 v1.0.24
  • v3/examples/server/go.sum — add github.com/wailsapp/wails/webview2 v1.0.24

Test plan

  • go mod tidy ran successfully on Windows (go1.26.2 windows/amd64) in all six directories
  • go build . in each example directory on Windows (no CGo errors, no missing go.sum entries)

Summary by CodeRabbit

  • Chores
    • Updated Go module dependencies for the gin-service example. This is an internal dependency update with no user-facing behavioral changes; it helps keep the example build environment current and more reliable.

Review Change Stack

…ntries

Six examples (dev, file-association, gin-routing, gin-service, notifications,
server) had go.sum files missing the Windows-only webview2 dependency
(github.com/wailsapp/wails/webview2), causing `go build .` to fail on Windows
with "missing go.sum entry for module providing package
github.com/wailsapp/wails/webview2/pkg/edge".

Fixes wailsapp#4042
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2f5a94aa-0ad5-4078-8ccd-1f7312e38f33

📥 Commits

Reviewing files that changed from the base of the PR and between 6a01e85 and 99639e0.

📒 Files selected for processing (1)
  • v3/examples/gin-service/go.mod
✅ Files skipped from review due to trivial changes (1)
  • v3/examples/gin-service/go.mod

Walkthrough

The gin-service example's go.mod adds the indirect dependency github.com/coder/websocket v1.8.14 in its secondary require block.

Changes

Dependency Update

Layer / File(s) Summary
Indirect Dependency Addition
v3/examples/gin-service/go.mod
Adds github.com/coder/websocket v1.8.14 // indirect to the module's require block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Windows, v3-alpha, size:XS

Suggested reviewers

  • leaanthony

Poem

🐰 A websocket drifts in sight,
Hidden in modules, out of light,
Gin-service hums, dependencies tight,
A small hop, version set just right,
Cheerful rabbit, code's delight.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description is comprehensive and complete, covering summary, affected examples, specific changes, and test plan. However, the required template sections (Type of change checkboxes, How Has This Been Tested details, and Checklist) are not filled out. While the description content is thorough, complete the required template sections including Type of change checkboxes, testing details for each platform, and the PR checklist to ensure full compliance with the repository's standards.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating go.sum files to include the Windows webview2 dependency, which directly matches the PR's primary objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.1)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leaanthony leaanthony merged commit 798b47d into wailsapp:master May 11, 2026
53 checks passed
leaanthony pushed a commit to taliesin-ai/wails that referenced this pull request May 11, 2026
…es): update go.sum files for Windows webview2 dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants