Fixes #11 - Error on macOS + Python 3#12
Merged
fohrloop merged 2 commits intowakepy:masterfrom Aug 28, 2021
mikeckennedy:master
Merged
Fixes #11 - Error on macOS + Python 3#12fohrloop merged 2 commits intowakepy:masterfrom mikeckennedy:master
fohrloop merged 2 commits intowakepy:masterfrom
mikeckennedy:master
Conversation
Member
|
Hi! The |
Contributor
Author
|
Oh, sorry! The signal import isn't needed. I originally was using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending text to the subprocess was resulting in the error #11 with bytes no string error. This PR fixes that and just uses
process.terminate(). Alternatively, you could doprocess.send_signal(signal.SIGINT)if you really want.