Conversation
fohrloop
force-pushed
the
run-mypy-on-multiple-versions-of-python
branch
from
bbfffc1 to
9e17b67
Compare
fohrloop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As wakepy is a type annotated library and supports python versions from 3.7 to 3.12, and supported type annotations depend on the used version of python, the mypy checks should be running also on versions other than 3.10.
Added mypy checks to CI pipelines, running on Python 3.7, 3.8, 3.9, 3.11 and 3.12
This revealed that the static type checks were failing on versions 3.7-3.9. Fixed the errors.