Enhance Mode Activation Observability: Better Logs and Diagnostics#430
Merged
Enhance Mode Activation Observability: Better Logs and Diagnostics#430
Conversation
1d82758 to
33f211d
Compare
d49c10b to
b0d912e
Compare
update activation result text and some mode related logs/warnings NoMethodsWarning
b0d912e to
d5b51f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #411
Examples
Test script:
When activation successful:
Shows clearly the different stages, the different methods to be used and the outcome. Both DEBUG and INFO level logs.
Example of failure
Shows which methods were tried, in what order, and why they failed
Example of the ActivationResult.get_failure_text()
which could print:
Example of NoMethodsWarning
When running:
example output: