-
Notifications
You must be signed in to change notification settings - Fork 18
Bump org.eclipse.lsp4j:org.eclipse.lsp4j from 0.8.1 to 0.24.0 #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump org.eclipse.lsp4j:org.eclipse.lsp4j from 0.8.1 to 0.24.0 #236
Conversation
Bumps [org.eclipse.lsp4j:org.eclipse.lsp4j](https://github.com/eclipse-lsp4j/lsp4j) from 0.8.1 to 0.24.0. - [Release notes](https://github.com/eclipse-lsp4j/lsp4j/releases) - [Changelog](https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md) - [Commits](eclipse-lsp4j/lsp4j@v0.8.1...v0.24.0) --- updated-dependencies: - dependency-name: org.eclipse.lsp4j:org.eclipse.lsp4j dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…ipse.lsp4j-0.24.0
…ipse.lsp4j-0.24.0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
============================================
- Coverage 58.48% 58.46% -0.02%
Complexity 516 516
============================================
Files 109 109
Lines 7286 7290 +4
Branches 827 828 +1
============================================
+ Hits 4261 4262 +1
- Misses 2849 2851 +2
- Partials 176 177 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the LSP4J dependency from 0.8.1 to 0.24.0 and adjusts related code to accommodate API changes while adding a Guava dependency.
- Upgrade of org.eclipse.lsp4j to 0.24.0
- Addition of Guava dependency in pom.xml files
- Updates in ClientDriver.java and ServerTest.java to align with the new API changes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pom.xml | Updated LSP4J version and added a Guava dependency with a specific version |
| com.ibm.wala.cast.python/pom.xml | Added Guava dependency without a version specification |
| com.ibm.wala.cast.python.ml/driver/ClientDriver.java | Replaced TextDocumentPositionParams with HoverParams to match updated API usage |
| com.ibm.wala.cast.python.ml.test/ServerTest.java | Updated type checks from SymbolInformation to DocumentSymbol and added WorkspaceSymbol handling |
Comments suppressed due to low confidence (3)
com.ibm.wala.cast.python/pom.xml:43
- The newly added Guava dependency does not specify a version, which can lead to inconsistent builds. Please specify an explicit version to ensure reproducible dependency resolution.
<dependency>
com.ibm.wala.cast.python.ml/source/com/ibm/wala/cast/python/ml/driver/ClientDriver.java:133
- Replacing TextDocumentPositionParams with HoverParams represents a significant API change; please confirm that this alteration aligns with the new LSP4J API and update any related documentation or method comments accordingly.
id.setUri(args[0]);
com.ibm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/ServerTest.java:165
- The test adjustments replacing SymbolInformation with DocumentSymbol and adding WorkspaceSymbol handling indicate API changes; please ensure the test expectations reflect the updated behavior of the LSP4J client.
} else if (s instanceof DocumentSymbol) {
Bumps [org.eclipse.lsp4j:org.eclipse.lsp4j](https://github.com/eclipse-lsp4j/lsp4j) from 0.8.1 to 0.24.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eclipse-lsp4j/lsp4j/releases">org.eclipse.lsp4j:org.eclipse.lsp4j's releases</a>.</em></p> <blockquote> <h2>v0.24.0</h2> <p>LSP4J <a href="https://projects.eclipse.org/projects/technology.lsp4j/releases/0.24.0">0.24.0</a> has now been released and been contributed to simrel, tagged and uploaded to maven central.</p> <ul> <li><a href="https://search.maven.org/search?q=g:org.eclipse.lsp4j">maven search</a></li> <li><a href="https://repo1.maven.org/maven2/org/eclipse/lsp4j/org.eclipse.lsp4j/0.24.0/">maven url</a></li> <li><a href="https://download.eclipse.org/lsp4j/updates/releases/0.24.0/">p2 site</a> (<a href="https://download.eclipse.org/lsp4j/updates/releases/0.24.0/v0.24.0.zip">zipped</a>)</li> <li><a href="https://github.com/eclipse/lsp4j/releases/tag/v0.24.0">git tag</a></li> <li><a href="https://download.eclipse.org/lsp4j/updates/releases/0.24.0/japicmp-report">japicmp report</a></li> </ul> <h2><a href="https://github.com/eclipse/lsp4j/blob/master/CHANGELOG.md">Changelog</a> entry</h2> <h3><a href="https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.24.0">v0.24.0 (Jan 2025)</a></h3> <ul> <li>Implemented DAP version 1.69.0</li> </ul> <p>Fixed issues: <a href="https://github.com/eclipse-lsp4j/lsp4j/milestone/35?closed=1">https://github.com/eclipse-lsp4j/lsp4j/milestone/35?closed=1</a></p> <p>Breaking API changes:</p> <p>japicmp report: <a href="https://download.eclipse.org/lsp4j/updates/releases/0.24.0/japicmp-report/">https://download.eclipse.org/lsp4j/updates/releases/0.24.0/japicmp-report/</a></p> <h2>What's Changed</h2> <ul> <li>Prepare repo for 0.24.0 development by <a href="https://github.com/jonahgraham"><code>@jonahgraham</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/835">eclipse-lsp4j/lsp4j#835</a></li> <li>broaden gson range, bundle new gson and guava by <a href="https://github.com/cdietrich"><code>@cdietrich</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/837">eclipse-lsp4j/lsp4j#837</a></li> <li>Add v0.23.1 to changelog by <a href="https://github.com/jonahgraham"><code>@jonahgraham</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/839">eclipse-lsp4j/lsp4j#839</a></li> <li>Update to latest japicmp tool release by <a href="https://github.com/jonahgraham"><code>@jonahgraham</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/841">eclipse-lsp4j/lsp4j#841</a></li> <li><a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/830">#830</a> Add module-info to the modules by <a href="https://github.com/Thihup"><code>@Thihup</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/843">eclipse-lsp4j/lsp4j#843</a></li> <li>Unsupported Operation Exception in Language Servers - Fixes <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/853">#853</a> by <a href="https://github.com/gilbysunil14"><code>@gilbysunil14</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/854">eclipse-lsp4j/lsp4j#854</a></li> <li>Update build settings for changes to JIPP as a result of recent LTS update by <a href="https://github.com/cdietrich"><code>@cdietrich</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/860">eclipse-lsp4j/lsp4j#860</a></li> <li>Sync DAP interfaces and types with DAP 1.69.x spec by <a href="https://github.com/jansorg"><code>@jansorg</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/863">eclipse-lsp4j/lsp4j#863</a></li> <li>fix: ClassCastException when handling "textDocument/inlineValue" event by <a href="https://github.com/sebthom"><code>@sebthom</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/867">eclipse-lsp4j/lsp4j#867</a></li> <li>Revert "Add module-info to the modules" by <a href="https://github.com/jonahgraham"><code>@jonahgraham</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/868">eclipse-lsp4j/lsp4j#868</a></li> <li>Update changelog + readme to close off 0.24.0 and prep 1.0.0 by <a href="https://github.com/jonahgraham"><code>@jonahgraham</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/869">eclipse-lsp4j/lsp4j#869</a></li> <li>Prepare repo for 0.24.0 release by <a href="https://github.com/jonahgraham"><code>@jonahgraham</code></a> in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/870">eclipse-lsp4j/lsp4j#870</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/Thihup"><code>@Thihup</code></a> made their first contribution in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/843">eclipse-lsp4j/lsp4j#843</a></li> <li><a href="https://github.com/gilbysunil14"><code>@gilbysunil14</code></a> made their first contribution in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/854">eclipse-lsp4j/lsp4j#854</a></li> <li><a href="https://github.com/jansorg"><code>@jansorg</code></a> made their first contribution in <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/pull/863">eclipse-lsp4j/lsp4j#863</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/eclipse-lsp4j/lsp4j/compare/v0.23.0...v0.24.0">https://github.com/eclipse-lsp4j/lsp4j/compare/v0.23.0...v0.24.0</a></p> <h2>v0.23.1</h2> <p>LSP4J <a href="https://projects.eclipse.org/projects/technology.lsp4j/releases/0.23.1">0.23.1</a> has now been released and been contributed to simrel, tagged and uploaded to maven central.</p> <ul> <li><a href="https://search.maven.org/search?q=g:org.eclipse.lsp4j">maven search</a></li> <li><a href="https://repo1.maven.org/maven2/org/eclipse/lsp4j/org.eclipse.lsp4j/0.23.1/">maven url</a></li> <li><a href="https://download.eclipse.org/lsp4j/updates/releases/0.23.1/">p2 site</a> (<a href="https://download.eclipse.org/lsp4j/updates/releases/0.23.1/v0.23.1.zip">zipped</a>)</li> <li><a href="https://github.com/eclipse/lsp4j/releases/tag/v0.23.1">git tag</a></li> <li><a href="https://download.eclipse.org/lsp4j/updates/releases/0.23.0/japicmp-report">japicmp report</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eclipse-lsp4j/lsp4j/blob/main/CHANGELOG.md">org.eclipse.lsp4j:org.eclipse.lsp4j's changelog</a>.</em></p> <blockquote> <h3><a href="https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.24.0">v0.24.0 (Jan 2025)</a></h3> <ul> <li>Implemented DAP version 1.69.0</li> </ul> <p>Fixed issues: <a href="https://github.com/eclipse-lsp4j/lsp4j/milestone/35?closed=1">https://github.com/eclipse-lsp4j/lsp4j/milestone/35?closed=1</a></p> <p>Breaking API changes:</p> <p>japicmp report: <a href="https://download.eclipse.org/lsp4j/updates/releases/0.24.0/japicmp-report/">https://download.eclipse.org/lsp4j/updates/releases/0.24.0/japicmp-report/</a></p> <h3><a href="https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.23.1">v0.23.1 (May 2024)</a></h3> <p>Fixed issues: <a href="https://github.com/eclipse-lsp4j/lsp4j/milestone/36?closed=1">https://github.com/eclipse-lsp4j/lsp4j/milestone/36?closed=1</a></p> <p>Breaking API changes:</p> <p>japicmp report: <a href="https://download.eclipse.org/lsp4j/updates/releases/0.23.1/japicmp-report/">https://download.eclipse.org/lsp4j/updates/releases/0.23.1/japicmp-report/</a></p> <h3><a href="https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.23.0">v0.23.0 (May 2024)</a></h3> <ul> <li>Implemented DAP version 1.65.0</li> </ul> <p>Fixed issues: <a href="https://github.com/eclipse-lsp4j/lsp4j/milestone/34?closed=1">https://github.com/eclipse-lsp4j/lsp4j/milestone/34?closed=1</a></p> <ul> <li>The exception handling around throwing <code>ResponseErrorException</code> has been improved to ensure that it is unwrapped to the expected <code>ResponseError</code> on the receiving side. In addition, <code>@JsonDelegate</code>s that throw exceptions have their checked exceptions wrapped in the more narrow <code>IllegalStateException</code> instead of a <code>RuntimeException</code>. <ul> <li>See <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/802">#802</a> for detailed discussion.</li> </ul> </li> </ul> <p>Breaking API changes:</p> <ul> <li>DAP version 1.61 removed unused <code>ModulesViewDescriptor</code></li> </ul> <p>japicmp report: <a href="https://download.eclipse.org/lsp4j/updates/releases/0.23.0/japicmp-report/">https://download.eclipse.org/lsp4j/updates/releases/0.23.0/japicmp-report/</a></p> <h3><a href="https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.22.0">v0.22.0 (February 2024)</a></h3> <p>Fixed issues: <a href="https://github.com/eclipse-lsp4j/lsp4j/milestone/29?closed=1">https://github.com/eclipse-lsp4j/lsp4j/milestone/29?closed=1</a></p> <ul> <li>The <code>org.eclipse.lsp4j.websocket</code> bundle has been deprecated in preparation for removal in the future. <ul> <li>Please migrate to <code>org.eclipse.lsp4j.websocket.jakarta</code></li> <li>The <code>org.eclipse.lsp4j.websocket</code> bundle is no longer included in the SDK feature nor published to Eclipse SimRel</li> <li>See <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/647">#647</a> for detailed discussion.</li> </ul> </li> </ul> <p>Breaking API changes:</p> <ul> <li>The Message class now has a new transient field, <code>jsonHandler</code>, to enable the <code>toString</code> implementation to properly format messages when custom type adapters are used. <ul> <li>For consumers that have their own custom serializers or other reflective message processors they may need to be updated to ensure that transient fields are skipped, for example by using <a href="https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/reflect/Modifier.html#isTransient(int)"><code>Modifier.isTransient</code></a></li> <li>See <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/768">#768</a> for detailed discussion.</li> </ul> </li> <li>The name field in WorkspaceFolder is no longer optional according to the specification. <ul> <li>See <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/741">#741</a> for detailed discussion.</li> </ul> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/202c299f0b066e1c6048998bad917bc9fe988cab"><code>202c299</code></a> Prepare repo for 0.24.0 release (<a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/870">#870</a>)</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/513bd730e152f4fc40f2632c11ffc1bf94dface5"><code>513bd73</code></a> Update changelog + readme to close off 0.24.0 and prep 1.0.0 (<a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/869">#869</a>)</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/10515b13185f2932663ae11bd080e195cea7ef74"><code>10515b1</code></a> Revert "Add module-info to the modules" (<a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/868">#868</a>)</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/db85990e6f6618c8e54d6b43f7ece3d088b48a5f"><code>db85990</code></a> fix: ClassCastException when handling "textDocument/inlineValue" event</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/651eb49e1f4cd90439808885ddaad0862b330908"><code>651eb49</code></a> Merge pull request <a href="https://redirect.github.com/eclipse-lsp4j/lsp4j/issues/863">#863</a> from jansorg/dap-spec-sync</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/ac74e5ba57b1a6dcf119a8ba764a488f95240af1"><code>ac74e5b</code></a> Update DAP version to 1.69.0</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/6e7761810574ee42d7040cc8b3041400efb51a27"><code>6e77618</code></a> Fix inconsistency in "evaluate" description</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/39eb3f73892694619ad6bbd115fa3fddf9f7b5a3"><code>39eb3f7</code></a> Clarify of variableReference after setVariable</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/a3216f0b9826b9faf4f5ad4165a84caea50e58af"><code>a3216f0</code></a> Clarify meaning of "system process"</li> <li><a href="https://github.com/eclipse-lsp4j/lsp4j/commit/bf7a554dbb610efc6fd2176829d0a136eec954e6"><code>bf7a554</code></a> Add supportsANSIStyling capabilities to allow colorization of text from debug...</li> <li>Additional commits viewable in <a href="https://github.com/eclipse-lsp4j/lsp4j/compare/v0.8.1...v0.24.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Raffi Khatchadourian <khatchad@hunter.cuny.edu>
Bumps org.eclipse.lsp4j:org.eclipse.lsp4j from 0.8.1 to 0.24.0.
Release notes
Sourced from org.eclipse.lsp4j:org.eclipse.lsp4j's releases.
... (truncated)
Changelog
Sourced from org.eclipse.lsp4j:org.eclipse.lsp4j's changelog.
... (truncated)
Commits
202c299Prepare repo for 0.24.0 release (#870)513bd73Update changelog + readme to close off 0.24.0 and prep 1.0.0 (#869)10515b1Revert "Add module-info to the modules" (#868)db85990fix: ClassCastException when handling "textDocument/inlineValue" event651eb49Merge pull request #863 from jansorg/dap-spec-syncac74e5bUpdate DAP version to 1.69.06e77618Fix inconsistency in "evaluate" description39eb3f7Clarify of variableReference after setVariablea3216f0Clarify meaning of "system process"bf7a554Add supportsANSIStyling capabilities to allow colorization of text from debug...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)