Skip to content

Add NewSiteReference to toString() in AllocationSiteInNode#1735

Merged
liblit merged 2 commits intowala:masterfrom
ponder-lab:1733_allocation_site_in_node_to_string
Oct 17, 2025
Merged

Add NewSiteReference to toString() in AllocationSiteInNode#1735
liblit merged 2 commits intowala:masterfrom
ponder-lab:1733_allocation_site_in_node_to_string

Conversation

@khatchad
Copy link
Copy Markdown
Contributor

@khatchad khatchad commented Oct 17, 2025

The return value of com.ibm.wala.ipa.callgraph.propagation.AllocationSiteInNode.toString() now includes its com.ibm.wala.classLoader.NewSiteReference. I used the toString() method of AllocationSite as a guide.

Fixes #1733.

@khatchad khatchad changed the title Add the new site reference to toString() in AllocationSiteInNode Add NewSiteReference to toString() in AllocationSiteInNode Oct 17, 2025
@liblit liblit self-requested a review October 17, 2025 14:27
Copy link
Copy Markdown
Contributor

@liblit liblit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @khatchad!

When this change is approved and squashed into master, the description of this PR will become the commit message. The current description, "Fixes #1733", will be completely opaque if, for example, we were ever to migrate off of GitHub. @khatchad, would you please expand that description to explain the purpose of the change even if the #1733 link is not available? Feel free to copy and paste anything from the original #1733 bug report. And feel free to keep the #1733 reference as part of the description. It just shouldn't be the entire description.

@liblit liblit enabled auto-merge October 17, 2025 14:28
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.22%. Comparing base (913a6e1) to head (897a0e3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1735      +/-   ##
============================================
- Coverage     50.22%   50.22%   -0.01%     
+ Complexity    12653    12652       -1     
============================================
  Files          1365     1365              
  Lines         85189    85190       +1     
  Branches      14726    14726              
============================================
- Hits          42788    42783       -5     
- Misses        37604    37605       +1     
- Partials       4797     4802       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 17, 2025

Test Results

  841 files  ±0    841 suites  ±0   5h 50m 36s ⏱️ + 51m 52s
  789 tests ±0    770 ✅ ±0   19 💤 ±0  0 ❌ ±0 
5 407 runs  ±0  5 272 ✅ ±0  135 💤 ±0  0 ❌ ±0 

Results for commit 897a0e3. ± Comparison against base commit 913a6e1.

♻️ This comment has been updated with latest results.

@khatchad khatchad requested a review from liblit October 17, 2025 14:47
@liblit liblit added this pull request to the merge queue Oct 17, 2025
Merged via the queue into wala:master with commit 5dd5444 Oct 17, 2025
12 of 13 checks passed
@khatchad khatchad deleted the 1733_allocation_site_in_node_to_string branch October 18, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The return value of com.ibm.wala.ipa.callgraph.propagation.AllocationSiteInNode.toString() doesn't include its com.ibm.wala.classLoader.NewSiteReference

2 participants