Add NewSiteReference to toString() in AllocationSiteInNode#1735
Add NewSiteReference to toString() in AllocationSiteInNode#1735liblit merged 2 commits intowala:masterfrom
NewSiteReference to toString() in AllocationSiteInNode#1735Conversation
toString() in AllocationSiteInNodeNewSiteReference to toString() in AllocationSiteInNode
liblit
left a comment
There was a problem hiding this comment.
Thanks, @khatchad!
When this change is approved and squashed into master, the description of this PR will become the commit message. The current description, "Fixes #1733", will be completely opaque if, for example, we were ever to migrate off of GitHub. @khatchad, would you please expand that description to explain the purpose of the change even if the #1733 link is not available? Feel free to copy and paste anything from the original #1733 bug report. And feel free to keep the #1733 reference as part of the description. It just shouldn't be the entire description.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1735 +/- ##
============================================
- Coverage 50.22% 50.22% -0.01%
+ Complexity 12653 12652 -1
============================================
Files 1365 1365
Lines 85189 85190 +1
Branches 14726 14726
============================================
- Hits 42788 42783 -5
- Misses 37604 37605 +1
- Partials 4797 4802 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The return value of
com.ibm.wala.ipa.callgraph.propagation.AllocationSiteInNode.toString()now includes itscom.ibm.wala.classLoader.NewSiteReference. I used thetoString()method ofAllocationSiteas a guide.Fixes #1733.