add-item-requests-and-gateway. Добавить запросы на вещи. Выделить валидацию в отдельный сервис. Написать тесты. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walder86
force-pushed
the
add-item-requests-and-gateway
branch
3 times, most recently
from
d8494ba to
34bacac
Compare
…идацию в отдельный сервис. Написать тесты.
walder86
force-pushed
the
add-item-requests-and-gateway
branch
from
34bacac to
ab9bbe3
Compare
irek-valiev
reviewed
Aug 26, 2025
There was a problem hiding this comment.
строчка 145 - эту логику нужно перенести в gateway
| @PathVariable Long requestId) { | ||
| return itemRequestService.getItemRequestById(userId, requestId); | ||
| } | ||
| } |
There was a problem hiding this comment.
не хватает эндпоинта GET /requests/all , на который можно получить список запросов, созданных другими пользователями
| public ItemRequestDto createItemRequest(ItemRequestDto itemRequestDto, Long requesterId) { | ||
| User user = userService.getUserWithCheck(requesterId); | ||
| ItemRequest newRequest = ItemRequestMapper.toItemRequest(itemRequestDto, user); | ||
| newRequest.setRequester(user); |
There was a problem hiding this comment.
пользователь и время уже добавлены в newRequest в ItemRequestMapper.toItemRequest()
… Перенести проверку на пустую строку для поиска вещей по тексту в гетвей.
irek-valiev
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.