Skip to content

Fix: Default ageGroup to 'All' for experiments#1

Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix/default-age-group
Draft

Fix: Default ageGroup to 'All' for experiments#1
google-labs-jules[bot] wants to merge 1 commit intomainfrom
fix/default-age-group

Conversation

@google-labs-jules
Copy link
Copy Markdown

This submission fixes a bug where experiments without a specified age group would default to '6-8' instead of 'All'. It also introduces the Vitest testing framework to the project and adds a new test case to verify the fix.


PR created automatically by Jules for task 2774336820149041978 started by @waldseelen

This commit adds the Vitest testing framework to the project to enable unit testing.

The following changes are included:
- Added `vitest`, `jsdom`, `@testing-library/react`, and `@testing-library/jest-dom` as dev dependencies.
- Configured Vitest in `vite.config.ts`.
- Created a test setup file at `src/tests/setup.ts`.
- Added a `test` script to `package.json`.

fix(data): Default ageGroup to 'All' for experiments

Previously, experiments without a specified `ageGroup` would incorrectly default to '6-8'. This commit changes the default to 'All' to accurately reflect that the experiment is suitable for all age groups.

The following changes are included:
- Updated the `getExperiment` and `getExperiments` functions in `src/data/experiments.ts` to default `ageGroup` to 'All'.
- Added a new test file `src/data/experiments.test.ts` to verify the fix and prevent regressions.
@google-labs-jules
Copy link
Copy Markdown
Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!


For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants