Refactor: Extract session saving logic into private method#4
Draft
Copilot wants to merge 2 commits intofeat/session-save-restorefrom
Draft
Refactor: Extract session saving logic into private method#4Copilot wants to merge 2 commits intofeat/session-save-restorefrom
Copilot wants to merge 2 commits intofeat/session-save-restorefrom
Conversation
Co-authored-by: walidsi <42148514+walidsi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix session restore functionality based on feedback
Refactor: Extract session saving logic into private method
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session saving logic was duplicated between
_doOpenTabandremoveFromOpenedFiles, creating maintenance burden and potential for inconsistencies.Changes
_saveSession()private method: Encapsulates session persistence logic (preference check, file collection across editor windows, data center update)_doOpenTabandremoveFromOpenedFilesnow delegate to_saveSession()Before:
After:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.