Skip to content

Potentially fix dependabot (again)#148

Merged
wallstop merged 6 commits intomasterfrom
dev/wallstop/fix-ci
Jan 28, 2026
Merged

Potentially fix dependabot (again)#148
wallstop merged 6 commits intomasterfrom
dev/wallstop/fix-ci

Conversation

@wallstop
Copy link
Copy Markdown
Owner

Description

These changes might help dependabot pass CI/CD

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor (code change that neither fixes a bug nor adds a feature)

Checklist

  • All tests pass locally
  • Code is properly formatted
  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have updated the CHANGELOG
  • My changes do not introduce breaking changes, or breaking changes are documented

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds path filters to GitHub Actions workflows to prevent unnecessary CI/CD runs, particularly helping Dependabot PRs pass CI more efficiently. By adding path filters, workflows will only trigger when relevant files are modified.

Changes:

  • Added path filters to 9 workflow files to limit when they trigger based on file changes
  • Added concurrency control to json-format-check.yml and csharpier-autofix.yml
  • Added workflow_dispatch trigger to dotnet-tests.yml for manual execution

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
.github/workflows/yaml-format-lint.yml Added path filters for YAML files and related configuration
.github/workflows/prettier-autofix.yml Added path filters for all file types that Prettier formats
.github/workflows/markdown-link-validity.yml Added path filters for markdown files and lychee configuration
.github/workflows/markdown-link-text-check.yml Added path filters for markdown files and Python validation scripts
.github/workflows/markdown-json.yml Added path filters for markdown, JSON, and related configuration
.github/workflows/lint-doc-links.yml Added path filters for markdown, docs, and linting scripts
.github/workflows/json-format-check.yml Added path filters for JSON files, concurrency control, and configuration
.github/workflows/dotnet-tests.yml Added path filters for .NET files and workflow_dispatch trigger
.github/workflows/csharpier-autofix.yml Added path filters for C# files and dotnet-tools configuration

Comment thread .github/workflows/yaml-format-lint.yml
Comment thread .github/workflows/yaml-format-lint.yml
Comment thread .github/workflows/prettier-autofix.yml
Comment thread .github/workflows/prettier-autofix.yml
Comment thread .github/workflows/yaml-format-lint.yml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (5)

.github/workflows/markdown-link-validity.yml:24

  • This workflow is missing required elements according to the new workflow consistency skill that's being introduced in this PR. It should include:
  1. A concurrency block with cancel-in-progress: true (before the jobs section)
  2. An explicit permissions block (even if just contents: read)
  3. A timeout-minutes on the job
  4. persist-credentials: false on the checkout step

All other workflows in this PR are being updated with these elements, but this one was only partially updated with path filters.

jobs:
  link-check:
    runs-on: ubuntu-latest
    steps:

.github/workflows/markdown-link-text-check.yml:24

  • This workflow is missing required elements according to the new workflow consistency skill. It should include:
  1. A concurrency block with cancel-in-progress: true (placed between on and jobs)
  2. An explicit permissions block (even if just contents: read)
  3. A timeout-minutes on the job
  4. persist-credentials: false on the checkout step

All other workflows in this PR are being updated with these elements, but this one was only partially updated with path filters.

jobs:
  check:
    runs-on: ubuntu-latest
    steps:

.github/workflows/lint-doc-links.yml:26

  • This workflow is missing required elements according to the new workflow consistency skill. It should include:
  1. A concurrency block with cancel-in-progress: true (placed between on and jobs)
  2. An explicit permissions block (even if just contents: read)
  3. A timeout-minutes on the job
  4. persist-credentials: false on the checkout step

All other workflows in this PR are being updated with these elements, but this one was only partially updated with path filters.

jobs:
  lint:
    runs-on: ubuntu-latest
    steps:

.github/workflows/markdown-json.yml:40

  • This workflow is missing required elements according to the new workflow consistency skill. It should include:
  1. A concurrency block with cancel-in-progress: true (placed between on and permissions)
  2. A timeout-minutes on the job
  3. persist-credentials: false on the checkout step
  4. The single quotes around node-version and cache should be changed to double quotes for Prettier consistency

The property order should also be: nameonconcurrencypermissionsjobs (currently permissions comes before concurrency should be added).

permissions:
  contents: read

jobs:
  validate:
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v6

.github/workflows/dotnet-tests.yml:28

  • This workflow is missing required elements according to the new workflow consistency skill. It should include:
  1. A concurrency block with cancel-in-progress: true (placed between on and permissions)
  2. A timeout-minutes on the job
  3. persist-credentials: false on the checkout step

The property order should also be: nameonconcurrencypermissionsjobs.

jobs:
  test:
    runs-on: ubuntu-latest

Comment thread .llm/skills/index.md Outdated
Comment thread .github/workflows/markdown-json.yml
Comment thread .llm/skills/index.md Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Comment thread scripts/__tests__/generate-skills-index.test.js Outdated
wallstop and others added 2 commits January 28, 2026 10:28
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@wallstop wallstop merged commit 48167e4 into master Jan 28, 2026
16 checks passed
@wallstop wallstop deleted the dev/wallstop/fix-ci branch January 28, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants