Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses issues with git add --renormalize commands failing in GitHub Actions workflows when file patterns don't match any files (exit code 128). The PR introduces a validation script, updates all workflows to use a safer per-extension loop pattern, and documents the required patterns.
Changes:
- Added a validation script to detect problematic git renormalize patterns
- Refactored all workflow files to use per-extension loops with existence checks
- Added comprehensive test coverage for the validation logic
- Updated documentation to describe the required pattern and validation process
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/validate-workflows.js |
New validation script that detects forbidden multi-pattern renormalize commands and missing existence checks |
scripts/validate-workflows.js.meta |
Unity meta file for the validation script |
scripts/__tests__/validate-workflows.test.js |
Comprehensive test suite for validation logic |
scripts/__tests__/validate-workflows.test.js.meta |
Unity meta file for the test file |
.github/workflows/prettier-autofix.yml |
Updated 3 renormalize commands to use per-extension loop pattern |
.github/workflows/format-on-demand.yml |
Updated 4 renormalize commands to use per-extension loop pattern |
.github/workflows/csharpier-autofix.yml |
Updated 3 renormalize commands to use per-extension loop pattern |
.github/workflows/actionlint.yml |
Added validation script execution to CI pipeline |
.llm/skills/github-actions/git-renormalize-patterns.md |
Documented required per-extension loop pattern and forbidden patterns, added verification section |
.llm/skills/index.md |
Updated line count for git-renormalize-patterns skill (266 → 348 lines) |
.llm/context.md |
Added guidance to use per-extension loops with existence checks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maybe this will fix dependabot?
Related Issue
Type of Change
Checklist