Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the docs and site styling to address the GitHub Pages banner SVG rendering issue (#171) by forcing transparency and refining banner presentation across light/dark modes and breakpoints.
Changes:
- Adjusts MkDocs banner container/image CSS to remove backgrounds and tune shadows responsively.
- Updates the banner SVG to use a subtler, semi-transparent backdrop intended to blend better with varying page backgrounds.
- Adds GitHub Pages/Jekyll theme CSS rules for banner transparency, sizing, responsiveness, and print behavior; updates sortable-table CSS to avoid
:has().
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/stylesheets/custom.css | Makes MkDocs banner container/image backgrounds transparent and adds responsive + theme-specific banner styling. |
| docs/images/unity-helpers-banner.svg | Tweaks SVG root and backdrop gradient/opacity to reduce harsh background appearance. |
| assets/css/theme.css | Adds banner-specific styling for the Jekyll/GitHub Pages theme (transparency/shadows/responsiveness/print). |
| assets/css/style.scss | Replaces :has() usage with a class-based selector for sortable table header indicators. |
Comment on lines
+704
to
706
| /* Base banner styles - works on any background */ | ||
| .md-typeset .md-banner img { | ||
| border-radius: 12px; |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Attempt at fixing #171
Related Issue
Fixes #
Type of Change
Checklist