Skip to content

Fix WValueDropDown + Documentation List Rendering Issues#213

Merged
wallstop merged 4 commits intomainfrom
dev/wallstop/wvalue-drop-down
Feb 27, 2026
Merged

Fix WValueDropDown + Documentation List Rendering Issues#213
wallstop merged 4 commits intomainfrom
dev/wallstop/wvalue-drop-down

Conversation

@wallstop
Copy link
Copy Markdown
Owner

Description

Clamp/Snap WValueDropDown/StringInList so rendering is fixed.

Cleaned up documentation so lists render appropriately.

Related Issue

Fixes #209
Fixes #210

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactor (code change that neither fixes a bug nor adds a feature)

Checklist

  • I have added tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have updated the CHANGELOG
  • My changes do not introduce breaking changes, or breaking changes are documented

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes dropdown rendering issues in Unity Helpers’ custom drawers (notably on Linux) and cleans up Markdown documentation list formatting, while bumping the package version to 3.2.1.

Changes:

  • Clamp invalid selected indices for WValueDropDown / StringInList IMGUI popups to avoid “phantom” rows.
  • Harden dropdown label rendering by providing non-empty fallback labels when option labels are null/empty.
  • Reformat multiple docs pages so nested lists and list/code-blocks render correctly; bump version + update changelog/templates/tests.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Bumps package version to 3.2.1.
docs/images/unity-helpers-banner.svg Updates banner’s displayed version string.
docs/features/utilities/reflection-helpers.md Adjusts list/code formatting for correct rendering.
docs/features/serialization/serialization-types.md Converts “Problem/Solution” lines into proper bullet lists.
docs/features/inspector/inspector-settings.md Fixes list formatting for settings documentation.
docs/features/effects/effects-system.md Fixes list nesting/numbering so docs render correctly on GitHub.
docs/features/editor-tools/editor-tools-guide.md Fixes list formatting for tool entries.
cspell.json Adds wvalue to dictionary.
Tests/Editor/CustomDrawers/WValueDropDownDrawerTests.cs Adds tests for selected-index resolution + label formatting fallbacks.
Tests/Editor/CustomDrawers/StringInListDrawerTests.cs Adds tests for unmatched values defaulting to first option in UI Toolkit selector.
Editor/CustomDrawers/WValueDropDownDrawer.cs Clamps EditorGUI.Popup index; ensures formatted labels are never empty; adds test hooks.
Editor/CustomDrawers/WDropDownPopupWindow.cs Adds fallback display text for empty option labels in popup rows.
Editor/CustomDrawers/StringInListDrawer.cs Clamps EditorGUI.Popup index for string/int/serializable-type modes.
Editor/CustomDrawers/Base/WDropDownSelectorBase.cs Adds fallback labels when building per-page dropdown choice text.
CHANGELOG.md Adds 3.2.1 entry describing the fix.
.llm/context.md Updates documented repo/package version.
.github/ISSUE_TEMPLATE/feature_request.yml Adds 3.2.1 (and 1.0.1) to package-version dropdown.
.github/ISSUE_TEMPLATE/bug_report.yml Adds 3.2.1 (and 1.0.1) to package-version dropdown.

Comment thread Editor/CustomDrawers/Base/WDropDownSelectorBase.cs Outdated
Comment thread Editor/CustomDrawers/WDropDownPopupWindow.cs Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

Comment thread CHANGELOG.md
@wallstop wallstop merged commit 85a8b41 into main Feb 27, 2026
32 checks passed
@wallstop wallstop deleted the dev/wallstop/wvalue-drop-down branch February 27, 2026 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: (Documentation) EffectSystem and Maybe Others Don't List Items [Bug]: WValueDropDown Has Tons of Empty Space at the Top

2 participants