Fix WValueDropDown + Documentation List Rendering Issues#213
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes dropdown rendering issues in Unity Helpers’ custom drawers (notably on Linux) and cleans up Markdown documentation list formatting, while bumping the package version to 3.2.1.
Changes:
- Clamp invalid selected indices for
WValueDropDown/StringInListIMGUI popups to avoid “phantom” rows. - Harden dropdown label rendering by providing non-empty fallback labels when option labels are null/empty.
- Reformat multiple docs pages so nested lists and list/code-blocks render correctly; bump version + update changelog/templates/tests.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumps package version to 3.2.1. |
| docs/images/unity-helpers-banner.svg | Updates banner’s displayed version string. |
| docs/features/utilities/reflection-helpers.md | Adjusts list/code formatting for correct rendering. |
| docs/features/serialization/serialization-types.md | Converts “Problem/Solution” lines into proper bullet lists. |
| docs/features/inspector/inspector-settings.md | Fixes list formatting for settings documentation. |
| docs/features/effects/effects-system.md | Fixes list nesting/numbering so docs render correctly on GitHub. |
| docs/features/editor-tools/editor-tools-guide.md | Fixes list formatting for tool entries. |
| cspell.json | Adds wvalue to dictionary. |
| Tests/Editor/CustomDrawers/WValueDropDownDrawerTests.cs | Adds tests for selected-index resolution + label formatting fallbacks. |
| Tests/Editor/CustomDrawers/StringInListDrawerTests.cs | Adds tests for unmatched values defaulting to first option in UI Toolkit selector. |
| Editor/CustomDrawers/WValueDropDownDrawer.cs | Clamps EditorGUI.Popup index; ensures formatted labels are never empty; adds test hooks. |
| Editor/CustomDrawers/WDropDownPopupWindow.cs | Adds fallback display text for empty option labels in popup rows. |
| Editor/CustomDrawers/StringInListDrawer.cs | Clamps EditorGUI.Popup index for string/int/serializable-type modes. |
| Editor/CustomDrawers/Base/WDropDownSelectorBase.cs | Adds fallback labels when building per-page dropdown choice text. |
| CHANGELOG.md | Adds 3.2.1 entry describing the fix. |
| .llm/context.md | Updates documented repo/package version. |
| .github/ISSUE_TEMPLATE/feature_request.yml | Adds 3.2.1 (and 1.0.1) to package-version dropdown. |
| .github/ISSUE_TEMPLATE/bug_report.yml | Adds 3.2.1 (and 1.0.1) to package-version dropdown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clamp/Snap
WValueDropDown/StringInListso rendering is fixed.Cleaned up documentation so lists render appropriately.
Related Issue
Fixes #209
Fixes #210
Type of Change
Checklist