Fix semantic sorting for benchmark Speed/Quality columns on GitHub Pages#249
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/wallstop/unity-helpers/sessions/036447c9-7b31-4a83-a8e3-1a193026de35 Co-authored-by: wallstop <1045249+wallstop@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add sorting functionality for performance benchmarks
Fix semantic sorting for benchmark Speed/Quality columns on GitHub Pages
Apr 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes GitHub Pages sortable table behavior so categorical benchmark labels (Speed/Quality) sort by intended semantic rank rather than lexicographic text, by adding data-sort-value support end-to-end (theme JS, markdown generation, docs, and regression tests).
Changes:
- Update the GitHub Pages table sorter to prefer
td[data-sort-value]with atextContentfallback. - Emit semantic
data-sort-valueattributes for Speed/Quality cells in random benchmark summary table generation and regenerate the rendered markdown. - Add a Node-based regression test and wire it into
validate:tests, plus document the pattern in the repo’s theming skill docs.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
_includes/head-custom.html |
Sorter now reads semantic sort keys via data-sort-value before falling back to cell text. |
Tests/Runtime/Performance/RandomBenchmarkMarkdownBuilder.cs |
Summary rows now include data-sort-value for Speed and Quality cells. |
docs/performance/random-performance.md |
Regenerated benchmark summary rows to include semantic sort metadata. |
scripts/tests/test-github-pages-sortable.js |
Adds regression coverage for sorter behavior and generated semantic attributes. |
scripts/tests/test-github-pages-sortable.js.meta |
Unity companion meta file for the new test script. |
package.json |
Registers the new test and includes it in validate:tests. |
.llm/skills/github-pages-theming.md |
Documents the data-sort-value pattern for categorical sorting on GitHub Pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GitHub Pages table sorting worked for numeric columns but produced incorrect ordering for categorical benchmark labels (e.g.,
Very SlownearVery Fast). This update adds semantic sort keys so benchmark tables sort by intended rank instead of lexicographic text.Sortable-table behavior
_includes/head-custom.htmlto prefertd[data-sort-value]over rendered cell text.Benchmark markdown generation
RandomBenchmarkMarkdownBuilderto emitdata-sort-valueforSpeedandQualitysummary cells.Fastest,Very Fast, etc.) while making sorting deterministic.Docs + guardrails
docs/performance/random-performance.mdsummary rows with semantic sort values.scripts/tests/test-github-pages-sortable.jsand wire it intovalidate:teststo prevent regressions..llm/skills/github-pages-theming.md.Related Issue
Addresses the GitHub Pages benchmark interactivity issue for column sorting intelligence (notably Speed/Quality categorical ordering).
Type of Change
Checklist