Skip to content

Conversation

@faridyagubbayli
Copy link
Collaborator

Closes #253

@codecov
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20890d2) 66.51% compared to head (6721665) 66.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #289      +/-   ##
==========================================
- Coverage   66.51%   66.45%   -0.07%     
==========================================
  Files          48       48              
  Lines        6998     6982      -16     
  Branches     1583     1579       -4     
==========================================
- Hits         4655     4640      -15     
  Misses       1728     1728              
+ Partials      615      614       -1     
Flag Coverage Δ
3.10 66.61% <100.00%> (-0.07%) ⬇️
3.11 66.61% <100.00%> (-0.07%) ⬇️
3.8 66.42% <100.00%> (-0.07%) ⬇️
3.9 66.42% <100.00%> (-0.07%) ⬇️
ubuntu-latest 66.39% <100.00%> (-0.07%) ⬇️
windows-latest 66.39% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@waltsims waltsims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Looks good to me!

As I mentioned in #291 it would be good to document how to create the .json files from potential new kWave releases. Perhaps we can add those instructions there.

@waltsims waltsims merged commit 52a2d1a into master Feb 4, 2024
@waltsims waltsims deleted the 253-remove-legacy-write-attributes branch February 4, 2024 17:36
@waltsims waltsims restored the 253-remove-legacy-write-attributes branch February 4, 2024 17:51
waltsims added a commit that referenced this pull request Feb 4, 2024
waltsims added a commit that referenced this pull request Feb 4, 2024
@waltsims
Copy link
Owner

waltsims commented Feb 4, 2024

@faridyagubbayli please look into this and re-open a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear up deprication warning

3 participants