Update local testing workflow instructions #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-python into artefact-dev-instructions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #291 +/- ##
=======================================
Coverage 67.24% 67.24%
=======================================
Files 48 48
Lines 7030 7030
Branches 1595 1595
=======================================
Hits 4727 4727
Misses 1711 1711
Partials 592 592
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…e-python into artefact-dev-instructions
…e-python into artefact-dev-instructions
Owner
Author
|
In the process of making this PR, I removed unused tests that are not run in the CI and added optional dependency installation testing in the CI. |
…e-python into artefact-dev-instructions
waltsims
commented
Feb 4, 2024
waltsims
commented
Feb 4, 2024
faridyagubbayli
approved these changes
Feb 22, 2024
Collaborator
faridyagubbayli
left a comment
faridyagubbayli
left a comment
There was a problem hiding this comment.
Some suggestions that are not blockers.
Co-authored-by: Farid Yagubbayli <faridyagubbayli@users.noreply.github.com>
Co-authored-by: Farid Yagubbayli <faridyagubbayli@users.noreply.github.com>
Co-authored-by: Farid Yagubbayli <faridyagubbayli@users.noreply.github.com>
Collaborator
Owner
Author
|
Yes |
Collaborator
|
As python 3.8 support was dropped, I removed it from the pipeline's test list and now tests are passing. |
waltsims
commented
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #129