phased array example #341
Merged
phased array example #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 67.77% 67.77%
=======================================
Files 48 48
Lines 7068 7068
Branches 1605 1605
=======================================
Hits 4790 4790
Misses 1697 1697
Partials 581 581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
djps
previously requested changes
Mar 12, 2024
waltsims
reviewed
Mar 15, 2024
| ([original example](http://www.k-wave.org/documentation/example_at_linear_array_transducer.php), [](https://colab.research.google.com/github/waltsims/k-wave-python/blob/master/examples/at_linear_array_transducer/at_linear_array_transducer.ipynb)) | ||
| - [Photoacoustic Waveforms](ivp_photoacoustic_waveforms/) ([original example](http://www.k-wave.org/documentation/example_ivp_photoacoustic_waveforms.php), [](https://colab.research.google.com/github/waltsims/k-wave-python/blob/master/examples/ivp_photoacoustic_waveforms/ivp_photoacoustic_waveforms.ipynb)) | ||
| - [Controling the PML](na_controlling_the_pml/) | ||
| - [Controlling the PML](na_controlling_the_pml/) |
Owner
There was a problem hiding this comment.
Thanks for catching these typos.
Comment on lines
+117
to
119
| steering_angle_max: max steering angle [deg] | ||
| steering_angle: steering angle [deg] | ||
Owner
|
Steps to merge:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.