Skip to content

Conversation

@djps
Copy link
Collaborator

@djps djps commented Mar 14, 2024

This should fix #288

@codecov
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.53%. Comparing base (0ce15a4) to head (7c33f43).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #343      +/-   ##
==========================================
+ Coverage   67.42%   67.53%   +0.11%     
==========================================
  Files          48       48              
  Lines        7024     7024              
  Branches     1596     1596              
==========================================
+ Hits         4736     4744       +8     
+ Misses       1701     1696       -5     
+ Partials      587      584       -3     
Flag Coverage Δ
3.10 67.69% <100.00%> (+0.11%) ⬆️
3.11 67.69% <100.00%> (+0.11%) ⬆️
3.12 67.69% <100.00%> (+0.11%) ⬆️
3.9 67.51% <100.00%> (+0.11%) ⬆️
ubuntu-latest 67.48% <100.00%> (+0.11%) ⬆️
windows-latest 67.48% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djps djps requested a review from faridyagubbayli March 14, 2024 11:25
@waltsims
Copy link
Owner

Thanks for taking this on David. The example still didn't run due to a type issue on diameter, which I have addressed. I also updated some of the plotting. By default, it seems matplotlib interpolates the plots, which I turned off to replicate MATLAB behavior.

@waltsims waltsims merged commit 231ebce into waltsims:master Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Failing example at_array_as_sensor.ipynb

2 participants