Bump sphinx-toolbox 3.8.0 -> 4.1.2 and sphinx-tabs 3.4.7 -> 3.4.5#733
Merged
Conversation
sphinx-toolbox 4.1.2 requires sphinx-tabs<3.4.7, so tabs is pinned to 3.4.5 (the highest version satisfying that constraint). The sphinx<9 pin from #714 is kept: sphinx-toolbox 4.1.2 still does `from sphinx.ext.autodoc import logger`, which Sphinx 9 removed. Supersedes #700 (toolbox bump) and #721 (tabs bump to 3.5.0, which cannot coexist with the toolbox 4.1.2 constraint). Verified locally: `uv sync --extra docs` resolves cleanly and `sphinx-build -b html docs/` completes successfully. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
=======================================
Coverage 75.04% 75.04%
=======================================
Files 56 56
Lines 8107 8107
Branches 1580 1580
=======================================
Hits 6084 6084
Misses 1404 1404
Partials 619 619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sphinx-toolboxfrom3.8.0to4.1.2andsphinx-tabsfrom3.4.7to3.4.5.sphinx-toolbox 4.1.2strictly requiressphinx-tabs<3.4.7, so tabs is pinned to3.4.5(the highest version that satisfies the constraint). Going to tabs3.5.0(what dependabot wanted in Bump sphinx-tabs from 3.4.7 to 3.5.0 #721) would requiresphinx-toolbox 4.2.0rc1, a pre-release — not worth shipping in the docs extras for now.sphinx<9pin from Pin sphinx<9 in docs extras to fix Read the Docs build #714 is kept: I verifiedsphinx-toolbox 4.1.2still doesfrom sphinx.ext.autodoc import logger, which Sphinx 9 removed (ImportError: cannot import name 'logger' from 'sphinx.ext.autodoc').Supersedes:
Test plan
uv sync --extra docsresolves cleanly with the new pinssphinx-build -b html docs/succeeds locally (134 pre-existing warnings, build succeeds)🤖 Generated with Claude Code
Greptile Summary
Bumps
sphinx-toolboxfrom 3.8.0 to 4.1.2 and intentionally downgradessphinx-tabsfrom 3.4.7 to 3.4.5 to satisfysphinx-toolbox 4.1.2's strictsphinx-tabs<3.4.7constraint. Thesphinx<9pin is preserved becausesphinx-toolbox 4.1.2still importsloggerfromsphinx.ext.autodoc, which Sphinx 9 removed.pyproject.tomlupdates both docs-extra pins with the correct compatible versions.uv.lockis regenerated and consistent with the new constraints inpyproject.toml.Confidence Score: 5/5
This PR is safe to merge — it touches only documentation build dependencies with no impact on the library's runtime behaviour.
The change is limited to two version pins in the docs optional-dependency group. The downgrade of sphinx-tabs and the preserved sphinx<9 upper bound are both correctly motivated by real upstream constraints that the author verified. The uv.lock is fully consistent with the updated pyproject.toml pins.
No files require special attention.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["sphinx-toolbox==4.1.2"] -->|"requires sphinx-tabs < 3.4.7"| B["sphinx-tabs==3.4.5 ✓"] A -->|"imports logger from sphinx.ext.autodoc\n(removed in Sphinx 9)"| C["sphinx < 9 pin kept ✓"] B --> D["docs build succeeds"] C --> D E["sphinx-tabs==3.4.5\n(was 3.4.7 — downgrade)"] --> B F["sphinx-toolbox==4.1.2\n(was 3.8.0 — upgrade)"] --> AReviews (2): Last reviewed commit: "Merge branch 'master' into chore/bump-sp..." | Re-trigger Greptile