Skip to content

Feat/tmf 2078 added qa field #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muhammad-tahir-nawaz merged 2 commits into from
Apr 4, 2026
Merged

Feat/tmf 2078 added qa field #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7aefac9
feat(TMF-2078): added qa report field
Apr 4, 2026
547ff32
feat(TMF-2078): added qa report field
Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@
## Why
<!-- Required: Explain why this change is needed. What problem does it solve? (minimum 20 characters) -->


## Dependencies
<!-- Optional: Does this change depend on another repo or PR? If yes, list them below. -->

None

## QA Report
<!-- Required: Upload a full-page screenshot of the QA HTML report below. -->
<!-- How to capture full-page screenshot: -->
Expand All @@ -23,7 +17,13 @@ None
## Integration Tests
<!-- Required: List integration tests added or edited in this PR. -->

- [ ] No integration tests required — Reason:
- [ ] No integration tests required

### Added / Edited
<!-- - [ ] `test name` — what it covers -->
### Added
<!-- - `test name` — what it covers -->

### Edited
<!-- - `test name` — what changed -->

## Dependencies
<!-- Optional: Does this change depend on another repo or PR? If yes, list them below. -->
11 changes: 7 additions & 4 deletions .github/workflows/pr-validation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,11 +162,14 @@ jobs:
exit 1
fi

# Validate Integration Tests section has at least one checked item
# Validate Integration Tests: either "No integration tests required" is checked, or tests are listed
tests_section=$(echo "$PR_BODY" | sed -n '/^## Integration Tests[[:space:]]*$/,/^## /p' | grep -v '^## ')
if ! echo "$tests_section" | grep -qE '\- \[x\]'; then
echo "❌ ## Integration Tests section has no checked items."
echo "Either check 'No integration tests required' with a reason, or list the tests added/edited."
has_no_tests_checked=$(echo "$tests_section" | grep -cE '\- \[x\] No integration tests required' || true)
has_tests_listed=$(echo "$tests_section" | grep -cE '^- `.+`' || true)
if [[ "$has_no_tests_checked" -eq 0 && "$has_tests_listed" -eq 0 ]]; then
echo "❌ ## Integration Tests section is incomplete."
echo "Either check 'No integration tests required' or list tests under Added/Edited."
echo "Format: - \`test name\` — description"
exit 1
fi

Expand Down
Loading