Experiments: multi node logging#1246
Merged
Merged
Conversation
Deploying docs with
|
| Latest commit: |
649dcea
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f63c3744.docodile.pages.dev |
| Branch Preview URL: | https://multi-node-runs.docodile.pages.dev |
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
noaleetz
reviewed
Apr 10, 2025
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 44.6%, saving 235.95 KB.
437 images did not require optimisation. |
noaleetz
reviewed
Apr 11, 2025
noaleetz
suggested changes
Apr 11, 2025
Contributor
noaleetz
left a comment
noaleetz
left a comment
There was a problem hiding this comment.
looks good! commented on including the console log experience in this shared mode (it is specific to shared mode / distributed setup).
noaleetz
reviewed
Apr 11, 2025
Contributor
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 46.2%, saving 263.42 KB.
438 images did not require optimisation. |
noaleetz
reviewed
Apr 15, 2025
noaleetz
reviewed
Apr 15, 2025
noaleetz
reviewed
Apr 16, 2025
noaleetz
reviewed
Apr 16, 2025
noaleetz
suggested changes
Apr 16, 2025
Contributor
noaleetz
left a comment
noaleetz
left a comment
There was a problem hiding this comment.
server release constraint
noaleetz
reviewed
Apr 17, 2025
mdlinville
requested changes
Apr 17, 2025
Contributor
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
The rest of my feedback -- please ignore anything where I've introduced errors or it doesn't make sense to you. I'm not so familiar with this area of content.
noaleetz
reviewed
Apr 17, 2025
noaleetz
reviewed
Apr 17, 2025
noaleetz
reviewed
Apr 17, 2025
noaleetz
reviewed
Apr 17, 2025
noaleetz
reviewed
Apr 17, 2025
noaleetz
suggested changes
Apr 17, 2025
Contributor
noaleetz
left a comment
noaleetz
left a comment
There was a problem hiding this comment.
missing server release constraint
noaleetz
approved these changes
Apr 18, 2025
mdlinville
approved these changes
Apr 18, 2025
Contributor
mdlinville
left a comment
mdlinville
left a comment
There was a problem hiding this comment.
Some small things, which I leave up to you whether to change or not. This is a big improvement to this page.
| 1. Checks the rank with the `--local_rank` command line argument. | ||
| 1. If the rank is set to 0, sets up `wandb` logging conditionally in the [`train()`](https://github.com/wandb/examples/blob/master/examples/pytorch/pytorch-ddp/log-ddp.py#L24) function. | ||
|
|
||
| ```python |
Contributor
There was a problem hiding this comment.
I still think this might be better to use the Prism shortcode since you explicitly name the script here. You can grep around for some examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up existing "Distributed logging" doc and adds a section on what and how to use public "Multi node" feature.
Jira ticket: https://wandb.atlassian.net/browse/DOCS-1373