Skip to content

chore: Need to create the workflow in main so it can be updated and run in v2 branch#127

Merged
danielpanzella merged 2 commits intomainfrom
danielpanzella/internal-image-publish-action
Feb 10, 2026
Merged

chore: Need to create the workflow in main so it can be updated and run in v2 branch#127
danielpanzella merged 2 commits intomainfrom
danielpanzella/internal-image-publish-action

Conversation

@danielpanzella
Copy link
Copy Markdown
Contributor

@danielpanzella danielpanzella commented Feb 10, 2026

Summary by CodeRabbit

  • Chores
    • Added a new manually-triggered CI workflow to publish internal container images. Users can specify an image tag when starting the workflow; it runs on the CI runner, checks out the repository and performs the release steps to prepare and push the specified image.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 10, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Adds a new GitHub Actions workflow file .github/workflows/internal-image-publish.yaml named "Internal Image Publish". It is manually triggerable via workflow_dispatch with a required image_tag input and defines a single Release job running on ubuntu-latest that checks out the repository with persist-credentials: false and fetch-depth: 0.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
.github/workflows/internal-image-publish.yaml
New workflow Internal Image Publish triggered via workflow_dispatch with required image_tag input. Defines a single Release job on ubuntu-latest and includes an actions/checkout@v2 step configured with persist-credentials: false and fetch-depth: 0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I stitched a workflow, neat and spry,

For images that reach the sky,
A manual nudge, a tag to share,
Checkout ready, runners prepare,
The rabbit hops — CI lights the way. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: creating a new workflow in the main branch for future updates and execution in the v2 branch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch danielpanzella/internal-image-publish-action

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.github/workflows/internal-image-publish.yaml:
- Line 17: The workflow uses an outdated action reference "actions/checkout@v2"
which pins Node 12 and will fail; update the checkout step to
"actions/checkout@v4" everywhere it appears in the workflow file (replace the
uses: value in the checkout step), commit the change, and verify any dependent
steps still work with the newer checkout action.

runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Update actions/checkout from v2 to v4.

actions/checkout@v2 uses Node.js 12, which is no longer supported on GitHub Actions runners and will fail. This is also flagged by actionlint.

Proposed fix
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
uses: actions/checkout@v2
uses: actions/checkout@v4
🧰 Tools
🪛 actionlint (1.7.10)

[error] 17-17: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue

(action)

🤖 Prompt for AI Agents
In @.github/workflows/internal-image-publish.yaml at line 17, The workflow uses
an outdated action reference "actions/checkout@v2" which pins Node 12 and will
fail; update the checkout step to "actions/checkout@v4" everywhere it appears in
the workflow file (replace the uses: value in the checkout step), commit the
change, and verify any dependent steps still work with the newer checkout
action.

@danielpanzella danielpanzella merged commit 802d886 into main Feb 10, 2026
8 of 9 checks passed
@danielpanzella danielpanzella deleted the danielpanzella/internal-image-publish-action branch February 10, 2026 02:40
j7m4 added a commit that referenced this pull request Mar 24, 2026
* chore: Upgrade go to 1.25.3 (#104)

* chore: Upgrade go to 1.25.3

* chore: Upgrade go to 1.25.3

* chore: Upgrade helm to 3.19.2 (#105)

* fix: Upgrade helm to 3.19.2 (#106)

* chore(release): version 1.21.3 [skip ci]

### [1.21.3](v1.21.2...v1.21.3) (2025-12-04)

### Bug Fixes

* Upgrade helm to 3.19.2 ([#106](#106)) ([aa4ca21](aa4ca21))

* chore: Need to create the workflow in main so it can be updated and run in v2 branch (#127)

* chore: Need to create the workflow in main so it can be updated and run in v2 branch

* chore: Add newline

* chore: Add empty workflow so it can be run in a branch (#131)

* fix to clickhouse enum we vendored (but is unused)

* work in progress on retention

* work in progress

* ONPREM-111 rentention/purge works for wandb delete

* ONPREM-111 more consistent label handling for retention

* ONPREM-111 more consistent label handling for retention

* initial retention e2e tests

* WIP: fix Redis PVC labeling for retention e2e tests

- Remove ensurePodLabels (operator SA lacks RBAC to patch pods, caused rapid requeue loop)
- Fix Redis PVC prefix: use crName-crName- pattern matching actual opstree PVC names
- Bypass cache for PVC reads in client (PVCs not watched, caused ErrCacheNotStarted)
- Add USE_EXISTING_CLUSTER=true to test-e2e-retention Makefile target
- Improve retention_test.go: namespace isolation, verifyComponentResourcesExist checks

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* ONPREM-111 complete impl of retention DETACH/PURGE policies

---------

Co-authored-by: Kevin Chen <140976422+wandb-kc@users.noreply.github.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Daniel Panzella <daniel.panzella@wandb.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants