chore: Need to create the workflow in main so it can be updated and run in v2 branch#127
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds a new GitHub Actions workflow file Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/internal-image-publish.yaml:
- Line 17: The workflow uses an outdated action reference "actions/checkout@v2"
which pins Node 12 and will fail; update the checkout step to
"actions/checkout@v4" everywhere it appears in the workflow file (replace the
uses: value in the checkout step), commit the change, and verify any dependent
steps still work with the newer checkout action.
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Update actions/checkout from v2 to v4.
actions/checkout@v2 uses Node.js 12, which is no longer supported on GitHub Actions runners and will fail. This is also flagged by actionlint.
Proposed fix
- uses: actions/checkout@v2
+ uses: actions/checkout@v4📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uses: actions/checkout@v2 | |
| uses: actions/checkout@v4 |
🧰 Tools
🪛 actionlint (1.7.10)
[error] 17-17: the runner of "actions/checkout@v2" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🤖 Prompt for AI Agents
In @.github/workflows/internal-image-publish.yaml at line 17, The workflow uses
an outdated action reference "actions/checkout@v2" which pins Node 12 and will
fail; update the checkout step to "actions/checkout@v4" everywhere it appears in
the workflow file (replace the uses: value in the checkout step), commit the
change, and verify any dependent steps still work with the newer checkout
action.
* chore: Upgrade go to 1.25.3 (#104) * chore: Upgrade go to 1.25.3 * chore: Upgrade go to 1.25.3 * chore: Upgrade helm to 3.19.2 (#105) * fix: Upgrade helm to 3.19.2 (#106) * chore(release): version 1.21.3 [skip ci] ### [1.21.3](v1.21.2...v1.21.3) (2025-12-04) ### Bug Fixes * Upgrade helm to 3.19.2 ([#106](#106)) ([aa4ca21](aa4ca21)) * chore: Need to create the workflow in main so it can be updated and run in v2 branch (#127) * chore: Need to create the workflow in main so it can be updated and run in v2 branch * chore: Add newline * chore: Add empty workflow so it can be run in a branch (#131) * fix to clickhouse enum we vendored (but is unused) * work in progress on retention * work in progress * ONPREM-111 rentention/purge works for wandb delete * ONPREM-111 more consistent label handling for retention * ONPREM-111 more consistent label handling for retention * initial retention e2e tests * WIP: fix Redis PVC labeling for retention e2e tests - Remove ensurePodLabels (operator SA lacks RBAC to patch pods, caused rapid requeue loop) - Fix Redis PVC prefix: use crName-crName- pattern matching actual opstree PVC names - Bypass cache for PVC reads in client (PVCs not watched, caused ErrCacheNotStarted) - Add USE_EXISTING_CLUSTER=true to test-e2e-retention Makefile target - Improve retention_test.go: namespace isolation, verifyComponentResourcesExist checks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * ONPREM-111 complete impl of retention DETACH/PURGE policies --------- Co-authored-by: Kevin Chen <140976422+wandb-kc@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Daniel Panzella <daniel.panzella@wandb.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary by CodeRabbit