fix: Openshift issues#167
Conversation
wnevis-cmyk
commented
Apr 28, 2026
- Fixes security context issues with minio-operator
- Adds flag for openshift for grafana-operator
- Adds support for fsGroup for strimzi-operator (and underlying kafka)
- Forces fsGroup 0 (root) for local crc deployments. Openshift should (?) automatically assign this in a regular openshift cluster
- Abstracts openshift-specific settings into a separate overlay
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| Name string `json:"name,omitempty"` | ||
| Telemetry Telemetry `json:"telemetry,omitempty"` | ||
| SkipDataRecovery bool `json:"skipDataRecovery,omitempty"` | ||
| FsGroup *int64 `json:"fsGroup,omitempty"` |
There was a problem hiding this comment.
is this something the user should be setting directly? it feels like a value we should be choosing.
There was a problem hiding this comment.
No, you're right, it shouldn't be. It should be set to 0 if it's an openshift deployment, and nil if not (at least, that's what worked in my dev environment).
There was a problem hiding this comment.
I've gone ahead and removed that from the API. Instead, I'm setting it via an environment variable which is configured via the overlay I'm using to push the podSecurityContext info for the controller-manager. Is that a better approach?