Conversation
WalkthroughThis pull request introduces multiple changes across CI/CD workflows, testing frameworks, Docker configuration, and code functionality. A new GitHub Actions workflow automates Docker image building and security scanning. The testing workflows have been updated to run test coverage and include a new build job. Environment adjustments include updated base images, improved logging with a Debug flag, configurable retry delays in the deployer, and enhanced testing via Ginkgo. Additionally, new Kubernetes manifests, dependency upgrades, and minor formatting adjustments are included in the changes. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User/Commit
participant GH as GitHub Actions
participant CHE as Checkout Step
participant DBX as Docker Buildx Setup
participant BD as Docker Build
participant TRV as Trivy Scan
U->>GH: Push/PR on main branch
GH->>CHE: Checkout repository code
CHE->>GH: Code checked out
GH->>DBX: Setup Docker Buildx
DBX->>GH: Buildx configured
GH->>BD: Build Docker image (using Git SHA tag)
BD->>GH: Image built
GH->>TRV: Run Trivy vulnerability scan
TRV->>GH: Return scan results
sequenceDiagram
participant C as Controller
participant DC as DeployerClient
C->>DC: GetSpec(options with Debug & RetryDelay)
alt Request Fails
DC-->>C: Return error and wait for RetryDelay
loop Retry until success or max retries
C->>DC: GetSpec(options)
DC-->>C: Error or eventual success
end
else Request Succeeds
DC-->>C: Return deployer spec
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again. Next stepsWhy is native code a concern?Contains native code (e.g., compiled binaries or shared libraries). Including native code can obscure malicious behavior. Verify that the inclusion of native code is expected and necessary for this package's functionality. If it is unnecessary or unexpected, consider using alternative packages without native code to mitigate potential risks. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (11)
hack/testing-manifests/kind/local-registry-config.yaml (3)
7-9: Confirm Hardcoded Authentication CredentialsThe configuration hardcodes
username = "admin"andpassword = "admin". While this is likely acceptable for a local test registry, please ensure that these credentials are never promoted to production. Adding a clarifying comment or an environment variable mechanism for non-local setups could reduce security risks.
10-11: Assess TLS Verification SettingsThe TLS configuration sets
insecure_skip_verify = true, which disables certificate verification. This is common for local testing but should be clearly documented to avoid unintended use in production environments.
15-15: Ensure Consistent File FormattingLine 15 appears without content. It is advisable to ensure that the file ends with a newline for POSIX compliance and consistency.
pkg/wandb/spec/charts/repo_test_helpers.go (2)
32-40: Consider adding configurable timeout.The client timeout is hardcoded to 10ms which might be too aggressive for some test scenarios.
func setupMockHTTPClient(responses map[string]*http.Response) *http.Client { +func setupMockHTTPClient(responses map[string]*http.Response, timeout time.Duration) *http.Client { + if timeout == 0 { + timeout = 10 * time.Millisecond + } return &http.Client{ Transport: &mockTransport{ responses: responses, timeout: 1 * time.Millisecond, }, - Timeout: 10 * time.Millisecond, + Timeout: timeout, } }
69-71: Add structured logging with key-value pairs.The current logging implementation only includes the message. Consider adding relevant key-value pairs for better debugging.
func (g *ginkgoLogSink) Info(level int, msg string, keysAndValues ...interface{}) { - ginkgo.GinkgoWriter.Printf("INFO: %s\n", msg) + ginkgo.GinkgoWriter.Printf("INFO: %s %v\n", msg, keysAndValues) } func (g *ginkgoLogSink) Error(err error, msg string, keysAndValues ...interface{}) { - ginkgo.GinkgoWriter.Printf("ERROR: %s: %v\n", msg, err) + ginkgo.GinkgoWriter.Printf("ERROR: %s: %v %v\n", msg, err, keysAndValues) }Also applies to: 73-75
pkg/wandb/spec/channel/deployer/deployer.go (1)
68-71: Consider adding jitter to retry delay.The current implementation uses a fixed delay between retries. Adding jitter can help prevent thundering herd problems in production.
+import "math/rand" retryDelay := opts.RetryDelay if retryDelay == 0 { retryDelay = 2 * time.Second } +// Add jitter of ±10% to the delay +jitter := time.Duration(float64(retryDelay) * (0.9 + 0.2*rand.Float64())) if err != nil || resp.StatusCode != http.StatusOK { - time.Sleep(retryDelay) + time.Sleep(jitter) continue }Also applies to: 86-89
pkg/wandb/spec/channel/deployer/deployer_test.go (1)
56-77: Consider testing intermediate retry attempts.The current test only verifies the final failure. Consider adding assertions for the number of retry attempts made.
+ retryCount := 0 server = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + retryCount++ w.WriteHeader(http.StatusBadGateway) _, _ = w.Write([]byte(`{}`)) })) // ... in the test Expect(err).To(HaveOccurred()) Expect(err.Error()).To(Equal("all retries failed")) Expect(got).To(BeNil()) + Expect(retryCount).To(Equal(5), "Expected 5 retry attempts")pkg/wandb/spec/charts/repo_test.go (2)
172-185: Add more test cases for ToLocalRelease.The test coverage for
ToLocalReleaseis minimal:
- Only tests failure scenarios
- Missing test cases for successful conversion
Consider adding test cases for successful conversion:
+ It("should successfully convert to LocalRelease with valid chart", func() { + server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + w.Write([]byte("chart-data")) + })) + defer server.Close() + repoRelease.URL = server.URL + + local, err := repoRelease.ToLocalRelease() + Expect(err).NotTo(HaveOccurred()) + Expect(local).NotTo(BeNil()) + })
217-238: Improve TLS verification test cases.The TLS verification tests could be more comprehensive:
- Missing test cases for invalid certificates
- No verification of actual TLS behavior
Consider adding test cases for TLS certificate validation:
+ It("should fail with invalid certificate", func() { + server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + w.WriteHeader(http.StatusOK) + })) + defer server.Close() + repoRelease.URL = server.URL + + _, err := repoRelease.downloadChart() + Expect(err).To(HaveOccurred()) + Expect(err.Error()).To(ContainSubstring("x509: certificate")) + }).github/workflows/docker-build-scan.yml (1)
29-37: Vulnerability Scanner Configuration – Consider Pinning a Stable Version
The Trivy scan step is well configured, scanning both OS and library vulnerabilities. However, usingaquasecurity/trivy-action@mastermay lead to unpredictable changes over time. It's advisable to pin to a stable release tag to ensure reproducibility.Example diff suggestion:
- uses: aquasecurity/trivy-action@master + uses: aquasecurity/trivy-action@v0.x.y(Replace
v0.x.ywith the latest stable release.)hack/testing-manifests/wandb/local-registry.yaml (1)
17-18: Basic Auth Credentials Handling – Verify Sensitive Information Handling
The manifest includes Basic Auth credentials (username: "admin"andpassword: "admin").
- Security Note: Although these may be acceptable for testing or sample deployments, hardcoding credentials can lead to security concerns. For production deployments, consider using Kubernetes Secrets or environment variables to manage sensitive data.
[security]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (19)
.github/workflows/docker-build-scan.yml(1 hunks).github/workflows/run-tests.yaml(1 hunks).gitignore(1 hunks)Dockerfile(1 hunks)Makefile(4 hunks)Tiltfile(2 hunks)controllers/weightsandbiases_controller.go(3 hunks)controllers/weightsandbiases_controller_test.go(1 hunks)go.mod(3 hunks)hack/testing-manifests/kind/local-registry-config.yaml(1 hunks)hack/testing-manifests/wandb/default.yaml(1 hunks)hack/testing-manifests/wandb/local-registry.yaml(1 hunks)main.go(1 hunks)pkg/wandb/spec/channel/deployer/deployer.go(3 hunks)pkg/wandb/spec/channel/deployer/deployer_test.go(1 hunks)pkg/wandb/spec/charts/repo.go(4 hunks)pkg/wandb/spec/charts/repo_test.go(1 hunks)pkg/wandb/spec/charts/repo_test_helpers.go(1 hunks)tilt-settings.sample.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- hack/testing-manifests/wandb/default.yaml
- Dockerfile
- main.go
🧰 Additional context used
🪛 GitHub Actions: Run Tests
Makefile
[error] 148-148: Command failed with exit code 1. ginkgo: command not found.
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-and-scan
🔇 Additional comments (34)
Tiltfile (2)
26-26: LGTM! Good security practice using minimal base image.Switching to
ubi9/ubi-microreduces the attack surface by using a minimal base image.
106-107: Verify the relationship with Basic Auth fix.While the dynamic path construction for WandB CRD is a good improvement, it's unclear how this change relates to the PR's objective of fixing Basic Auth issues.
Could you clarify how these Tilt configuration changes contribute to fixing Basic Auth?
tilt-settings.sample.json (2)
2-2: LGTM! Clean array formatting.The single-line format improves readability while maintaining functionality.
5-5: Verify the relationship with Basic Auth fix.The addition of the
wandbCRDsetting enhances configuration flexibility but appears unrelated to the PR's objective of fixing Basic Auth issues.Could you explain how this new setting contributes to fixing Basic Auth?
hack/testing-manifests/kind/local-registry-config.yaml (4)
1-2: Validate Cluster MetadataThe API version and kind values appear appropriate for a KIND cluster configuration. Please verify that
kind.x-k8s.io/v1alpha4is the intended version for your setup and that usingClusterfits your use case.
3-4: Verify Containerd Config Patches BlockThe
containerdConfigPatchessection uses the block literal style (|-), which intentionally omits the trailing newline. Confirm that this behavior is expected and that the indentation meets YAML specifications for your containerd configuration.
5-6: Review Registry Mirror Endpoint ConfigurationThe registry mirror is configured with
endpoint = ["http://registry:5000"]Ensure that the use of HTTP (without TLS) is acceptable for your local testing purposes. If there’s any chance this might be used outside of a trusted environment, consider adding a warning or comment regarding potential security implications.
12-14: Check Networking ConfigurationThe networking section specifies
ipFamily: dualand setsapiServerAddressto"127.0.0.1". Confirm that these settings align with your cluster’s network requirements and that the chosen values are intentional. Consider adding inline comments if these settings depend on specific testing environments.pkg/wandb/spec/charts/repo_test_helpers.go (1)
13-30: LGTM! Well-structured mock transport implementation.The
mockTransportimplementation correctly handles timeouts and provides configurable responses. The fallback to 404 for unknown URLs is a good practice.pkg/wandb/spec/channel/deployer/deployer.go (1)
28-29: LGTM! Good addition of configuration options.The new fields enhance the flexibility of the deployer client:
Debugflag for future debugging capabilitiesRetryDelayfor configurable retry intervalspkg/wandb/spec/channel/deployer/deployer_test.go (1)
31-54: LGTM! Well-structured test cases with proper assertions.The test cases effectively validate:
- HTTP headers
- Basic auth credentials
- Response handling
pkg/wandb/spec/charts/repo.go (2)
41-58: LGTM! Well-implemented repository name derivation.The
deriveRepoNamemethod provides a good fallback mechanism when explicit names aren't provided, with proper error handling.
208-215: LGTM! Robust URL handling for chart downloads.The code properly handles both absolute and relative chart URLs, ensuring compatibility with various repository structures.
pkg/wandb/spec/charts/repo_test.go (2)
39-86: LGTM! Well-structured test setup.The test setup is comprehensive and follows best practices:
- Creates temporary directories for test data
- Sets up mock responses with realistic test data
- Initializes logging capture
93-127: LGTM! Thorough test coverage for URL handling.The test cases for
deriveRepoNameare well-structured and cover important scenarios:
- Explicit repo names
- Various URL formats
- Error cases for invalid URLs
controllers/weightsandbiases_controller_test.go (1)
36-36: LGTM! Debug field addition.The Debug field is correctly added to the RepoRelease struct in the test configuration.
controllers/weightsandbiases_controller.go (2)
147-152: LGTM! Debug flag propagation.The Debug flag is correctly propagated to the GetSpec options.
160-162: LGTM! Improved error logging.Changed error logging to info level for better visibility of non-critical issues.
.gitignore (1)
18-22: LGTM! Appropriate test output exclusions.Added necessary exclusions for Ginkgo test output files:
- coverage.html
- report.json
- junit.xml
.github/workflows/docker-build-scan.yml (5)
1-8: Workflow Trigger & Metadata Configuration Looks Correct
The workflow is correctly set to trigger on pushes and pull requests to the main branch. The metadata (name, trigger settings) is clear and straightforward.
9-12: Job Definition Is Well Structured
Thebuild-and-scanjob is defined to run onubuntu-latest, which is appropriate for Docker builds and scanning operations.
13-15: Checkout Step Is Implemented Properly
The use ofactions/checkout@v4ensures the repository is properly checked out.
16-18: Docker Buildx Setup Is Configured Correctly
Usingdocker/setup-buildx-action@v3is the recommended way to set up Buildx on GitHub Actions.
19-28: Docker Image Build Step Is Correct
The Docker build step correctly usesdocker/build-push-action@v5with caching options. The image is tagged using the GitHub SHA (line 25), which aids traceability..github/workflows/run-tests.yaml (1)
24-34: New Build Job Is a Useful Addition
The newbuildjob is properly configured to check out the code, set up Go (v1.24), and runmake build. It provides a clear separation of concerns from testing.hack/testing-manifests/wandb/local-registry.yaml (3)
1-11: Deployment Manifest Metadata Is Detailed and Clear
The manifest’s metadata (kind, apiVersion, labels, and name) is comprehensive and follows standard Kubernetes conventions.
12-16: Helm Chart Specification Is Appropriately Defined
The chart details (URL, name, version) are explicitly set, providing clarity on what is being deployed.
19-123: Remaining Resource & Image Configuration Looks Consistent
The rest of the YAML correctly configures image repositories, tags, and resource requests for various components. Ensure that these static values match your environment’s expected settings.go.mod (4)
5-10: Dependency Updates Are In Line with Project Upgrades
New and updated dependencies such asgithub.com/go-logr/logr v1.4.2,github.com/onsi/ginkgo/v2 v2.22.2, andgithub.com/onsi/gomega v1.36.2are in keeping with recent improvements in testing and logging.
- Please verify that these updates do not introduce breaking changes within the codebase.
[verified]
74-77: Updated Indirect Dependency for google/pprof
The update togithub.com/google/pprof(line 74) is noted. Ensure that any functionality relying on pprof is tested against the new version.
138-139: golang.org/x/mod and golang.org/x/tools Updates Are Consistent
The updates togolang.org/x/modandgolang.org/x/tools(lines 138 and 146) should help maintain compatibility with the latest Go tooling improvements.
150-151: Protobuf Update Is Notable
The update forgoogle.golang.org/protobuf(line 150) should be tested to ensure no serialization/regression issues arise.Makefile (2)
61-66: macOS Linker Warnings Suppression Block
The conditional that setsCGO_LDFLAGSandLDFLAGSfor Darwin environments is a pragmatic solution to suppress linker warnings on macOS.
- Verify that this does not inadvertently hide important warnings during development or on CI.
317-321: Ginkgo Installation Target Is Defined Correctly
Theginkgotarget downloads and installs the Ginkgo testing binary into$(LOCALBIN), which is then assigned to theGINKGOvariable. This target is well defined; updating the test targets to use$(GINKGO)will resolve the pipeline error.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/run-tests.yaml (1)
26-37: Build Job Addition: Review Setup and Consider Caching
The introduction of the new Build job is a positive enhancement. To further optimize build times in the future, consider caching Go modules and dependencies. Additionally, confirm that all necessary environment variables (e.g., for GOPATH) remain consistent across jobs.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/run-tests.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Test
🔇 Additional comments (2)
.github/workflows/run-tests.yaml (2)
21-22: Ginkgo Installation: Validate Binary Path & Version Pinning
The new "Install Ginkgo" step usesgo install ...@latest, which meets the immediate need; however, please consider pinning a specific version instead of using@latestto avoid unexpected breaking changes in future builds. Also, ensure that the installed binary is added to the PATH (typically via$GOPATH/binor$HOME/go/bin). This note echoes previous feedback on handling the “ginkgo: command not found” issue.
24-24: Tests Step: Confirm Makefile Target and PATH Requirements
The "Tests" step now runsmake test-coverage, which aligns with the updated Makefile. Please double-check that the target properly invokes Ginkgo and that the PATH includes the directory holding the Ginkgo binary if required by your environment.
|
@coderabbitai This is how it is related to basic auth. Please create a diagram for that and update the description to include this. Also, if you can do an in-depth review on this logic, I would appreciate it.
chartRepo, err := repo.NewChartRepository(entry, providers)The previous version created a repo.NewChartRepository without explicitly ensuring that the authentication credentials were used for HTTP requests. After: entry.Username = r.Username
entry.Password = r.PasswordThe credentials are now explicitly set in the repo.Entry struct before initializing the repository, ensuring that private registries requiring authentication receive the correct credentials.
Options: []getter.Option{
getter.WithBasicAuth(r.Username, r.Password),
}While WithBasicAuth was used, it was inside client.DownloadTo, but the repo.NewChartRepository call itself did not get the authentication settings properly. getterOpts := []getter.Option{
getter.WithBasicAuth(r.Username, r.Password),
getter.WithInsecureSkipVerifyTLS(true),
}The authentication settings (WithBasicAuth) are now explicitly set before initializing repo.NewChartRepository. This ensures that all interactions with the private registry, including fetching the index file and downloading the chart, properly use the credentials.
chartURL, err := repo.FindChartInRepoURL(
entry.URL, entry.Name, r.Version,
"", "", "",
providers,
)The older implementation used repo.FindChartInRepoURL, but it wasn’t guaranteed to handle authentication correctly. if len(cv.URLs) == 0 {
return "", fmt.Errorf("chart %s version %s has no downloadable URLs", r.Name, r.Version)
}
chartURL := cv.URLs[0]
if !strings.HasPrefix(chartURL, "http://") && !strings.HasPrefix(chartURL, "https://") {
chartURL = fmt.Sprintf("%s/%s", strings.TrimSuffix(r.URL, "/"), chartURL)
}The new implementation ensures that: The rest of the code is around testing this change with tilt and the tests in the pipeline to make sure it is building with the image change. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@zacharyblasczyk Here's a sequence diagram showing the authentication flow for chart downloads, followed by an in-depth review of the implementation: sequenceDiagram
participant Client as RepoRelease
participant Entry as repo.Entry
participant ChartRepo as ChartRepository
participant Registry as Chart Registry
Client->>Entry: Set Username/Password
Note over Entry: entry.Username = r.Username<br/>entry.Password = r.Password
Client->>Entry: Configure getter.Options
Note over Entry: WithBasicAuth(Username, Password)<br/>WithInsecureSkipVerifyTLS(true)
Client->>ChartRepo: NewChartRepository(entry, providers)
ChartRepo->>Registry: GET /index.yaml
Note over Registry: Basic Auth: Username:Password
Registry-->>ChartRepo: Return index.yaml
ChartRepo->>ChartRepo: Find chart version
alt Relative URL in index
ChartRepo->>ChartRepo: Prepend base URL
Note over ChartRepo: fmt.Sprintf("%s/%s",<br/>strings.TrimSuffix(r.URL, "/"),<br/>chartURL)
end
ChartRepo->>Registry: GET /charts/chart-version.tgz
Note over Registry: Basic Auth: Username:Password
Registry-->>ChartRepo: Return chart archive
Review of the implementation:
The implementation is solid and addresses the authentication issues comprehensively. The changes ensure that authentication works correctly for both index file retrieval and chart downloads, while also handling URL resolution properly for private registries. 🐰 thoughtfully reviewing the authentication flow 🏁 Script executed: Length of output: 86 @zacharyblasczyk I apologize, but I need to verify the actual implementation in the codebase to ensure my previous analysis and diagram are accurate. Could you please confirm if the sequence diagram I provided matches the actual implementation? Additionally, I'd like to review the actual code to provide a more detailed and accurate analysis. In the meantime, I noticed that my previous diagram might need adjustments based on:
Would you like me to refine the diagram and provide a more detailed analysis once we can access the actual implementation? 🐰 carefully double-checking the implementation details 🏁 Script executed: Length of output: 55 🏁 Script executed: Length of output: 34 🏁 Script executed: Length of output: 82 @zacharyblasczyk I've located the relevant files and am fetching their contents to provide an accurate analysis. Once I have access to the actual implementation, I'll:
Would you like me to proceed with the detailed analysis once I have access to the implementation? 🐰 diligently gathering implementation details 🏁 Script executed: Length of output: 6255 🏁 Script executed: Length of output: 8933 @zacharyblasczyk Thank you for providing access to the implementation. I've updated the sequence diagram to accurately reflect the code, and here's my in-depth review: sequenceDiagram
participant Client as RepoRelease
participant Settings as Helm Settings
participant Repo as ChartRepo
participant Index as IndexFile
participant Registry as Chart Registry
Client->>Client: deriveRepoName()
Note over Client: Generate repo name from URL<br/>or use explicit RepoName
Client->>Settings: Configure Helm settings
Note over Settings: Set HELM_CACHE_HOME<br/>Set HELM_CONFIG_HOME<br/>Set HELM_DATA_HOME
Client->>Repo: Setup repository
Note over Repo: entry.Username = r.Username<br/>entry.Password = r.Password<br/>entry.InsecureSkipTLSverify = true
Client->>Repo: Configure getterOpts
Note over Repo: WithBasicAuth(Username, Password)<br/>WithInsecureSkipVerifyTLS(true)
Repo->>Registry: Download index file
Note over Registry: GET /index.yaml<br/>Basic Auth: Username:Password
Registry-->>Repo: Return index.yaml
Repo->>Index: Load and parse index
Note over Index: Find chart version<br/>Get download URLs
alt Relative Chart URL
Index->>Index: Prepend base URL
Note over Index: fmt.Sprintf("%s/%s",<br/>strings.TrimSuffix(r.URL, "/"),<br/>chartURL)
end
Client->>Registry: Download chart
Note over Registry: GET /charts/chart.tgz<br/>Basic Auth: Username:Password
Registry-->>Client: Return chart archive
Detailed Code Review:
The implementation is very robust and well-tested. The test suite covers various scenarios including:
🐰 thoroughly analyzing the implementation details ✏️ Learnings added
|
theishshah
left a comment
theishshah
left a comment
There was a problem hiding this comment.
we love more tests :)
|
Tests now look like this: I actually cut off 10 seconds from the tests (or more, can't remember). |
|
Old tests look like this: |
|
|
### [1.18.3](v1.18.2...v1.18.3) (2025-02-25) ### Bug Fixes * Basic Auth Fix ([#56](#56)) ([414b2cf](414b2cf))
|
This PR is included in version 1.18.3 🎉 |
## 1.0.0 (2025-04-11) ### Features * Add active-state cm ([wandb#2](https://github.com/sqaisar/wandb-operator/issues/2)) ([5a6c4c3](5a6c4c3)) * Add caching for deployer release requests ([1185b40](1185b40)) * Add events recording ([388d37b](388d37b)) * Add helm support ([077765c](077765c)) * Add option to set reconcileFrequency ([484c014](484c014)) * Add support for helm repo releases ([dfef752](dfef752)) * Add support for release from a git repository ([8a6b073](8a6b073)) * Adding owner ref and wait and timeout to uninstall ([wandb#51](https://github.com/sqaisar/wandb-operator/issues/51)) ([f21fd6d](f21fd6d)) * Allow the operator to support installation without cluster level permissions ([wandb#16](https://github.com/sqaisar/wandb-operator/issues/16)) ([6f29a3e](6f29a3e)) * Make wandb operator available on OperatorHub ([wandb#32](https://github.com/sqaisar/wandb-operator/issues/32)) ([1a59dab](1a59dab)) * **operator:** Add airgapped support ([wandb#12](https://github.com/sqaisar/wandb-operator/issues/12)) ([bfd3796](bfd3796)) * Prevent Logging of Sensitive info in Plain Text ([wandb#31](https://github.com/sqaisar/wandb-operator/issues/31)) ([5530cb3](5530cb3)) * Prevent Logging of Sensitive info in Plain Text ([wandb#35](https://github.com/sqaisar/wandb-operator/issues/35)) ([9a752fd](9a752fd)) * Release Version Pinning Init ([wandb#28](https://github.com/sqaisar/wandb-operator/issues/28)) ([dfe8bda](dfe8bda)) * Replace base image with RHEL UBI ([wandb#44](https://github.com/sqaisar/wandb-operator/issues/44)) ([12497d2](12497d2)) * Support for deploymenting via jobs ([da801ea](da801ea)) * Updated license.go file to include the feature for licenseSecret as well ([wandb#54](https://github.com/sqaisar/wandb-operator/issues/54)) ([bb55caa](bb55caa)) * Use container based deployments only ([3e6b222](3e6b222)) * use secrets instead of configmaps ([049797f](049797f)) ### Bug Fixes * add applied config to download bundle ([bef77c2](bef77c2)) * Add console namespace and service name to config properties ([0b9efef](0b9efef)) * Add debugging for installing release ([893ebd9](893ebd9)) * add gh token for ci ([72d456f](72d456f)) * add license log ([wandb#11](https://github.com/sqaisar/wandb-operator/issues/11)) ([e129fab](e129fab)) * Add operator namespace env ([846731a](846731a)) * add operator properties to config ([b5f48f0](b5f48f0)) * add pnpm, node and git to docker image ([176b6f0](176b6f0)) * Add Tilt configs for local development ([wandb#53](https://github.com/sqaisar/wandb-operator/issues/53)) ([5ef82b5](5ef82b5)) * added changelog commits ([61b5f5d](61b5f5d)) * Assign metadata instead of merging it ([908c839](908c839)) * Basic Auth Fix ([wandb#56](https://github.com/sqaisar/wandb-operator/issues/56)) ([414b2cf](414b2cf)) * Bump controller tools version to latest ([wandb#13](https://github.com/sqaisar/wandb-operator/issues/13)) ([c52dbb6](c52dbb6)) * Bump deps ([wandb#36](https://github.com/sqaisar/wandb-operator/issues/36)) ([eefb59c](eefb59c)) * Bump deps ([wandb#70](https://github.com/sqaisar/wandb-operator/issues/70)) ([11ba9f8](11ba9f8)) * Channel spec not getting applied correctly ([6e763a8](6e763a8)) * Charts download ([57355ce](57355ce)) * Clean up docker image ([ef7c629](ef7c629)) * clean up env for image push ([7213ed2](7213ed2)) * Correct merge order ([cd49cef](cd49cef)) * correctly check if chart is installed based on status ([384d330](384d330)) * Create release rc files ([f7f4622](f7f4622)) * Debug logging errors ([wandb#26](https://github.com/sqaisar/wandb-operator/issues/26)) ([a641621](a641621)) * Debug logging the cache ([wandb#21](https://github.com/sqaisar/wandb-operator/issues/21)) ([26e8fd5](26e8fd5)) * Debugging logic ([wandb#22](https://github.com/sqaisar/wandb-operator/issues/22)) ([2c019b8](2c019b8)) * Default to dev mode ([d961f77](d961f77)) * docker build ([d160a9c](d160a9c)) * docker image push ([e08b3da](e08b3da)) * Git release pulls correctly ([d47aebd](d47aebd)) * init controller ([0f0a9e9](0f0a9e9)) * install go version ([6664b4b](6664b4b)) * Install kubectl in docker image ([e5df9de](e5df9de)) * Jobs work? ([9972d26](9972d26)) * kubectl not working in docker image ([ffc694e](ffc694e)) * Local_resource and kubectl apply could risk deploying to the wrong context ([wandb#66](https://github.com/sqaisar/wandb-operator/issues/66)) ([a90a270](a90a270)) * lock pnpm version ([c2608f7](c2608f7)) * Log the diff of specs ([wandb#23](https://github.com/sqaisar/wandb-operator/issues/23)) ([c0ea0d8](c0ea0d8)) * Look for secret in namespace of wandb CR ([wandb#78](https://github.com/sqaisar/wandb-operator/issues/78)) ([e374c9a](e374c9a)) * Mask sensitive values in log ([wandb#14](https://github.com/sqaisar/wandb-operator/issues/14)) ([514336d](514336d)) * merge func ([94aa0d0](94aa0d0)) * Output json format logs ([90af7b6](90af7b6)) * Pass namespace into chart ([e8e0b8f](e8e0b8f)) * pass spec namespace and name ([79d77f2](79d77f2)) * Preserve unknown fields ([565a25f](565a25f)) * properly get license ([6ff6533](6ff6533)) * Properly merge chart specs together ([37c41bc](37c41bc)) * Properly parse chart from deployer ([5eabdfe](5eabdfe)) * Properly set namespace for deployments ([53f51a9](53f51a9)) * Properly update complete status ([86a5196](86a5196)) * push images to dockerhub ([d4cdd27](d4cdd27)) * refactor spec ([87be86b](87be86b)) * Refactor specs ([7c6da34](7c6da34)) * Release needs ginkgo ([wandb#65](https://github.com/sqaisar/wandb-operator/issues/65)) ([c51df78](c51df78)) * remove console ([fba45ee](fba45ee)) * remove debugging logs ([d4da31f](d4da31f)) * remove submodule ([bdb408a](bdb408a)) * Remove ui building step ([08ee985](08ee985)) * Rename config -> values and release -> chart ([519cd1b](519cd1b)) * Rename config spec cfs ([672100a](672100a)) * rename configs ([8727281](8727281)) * rename docker variables ([274e20c](274e20c)) * rename versioning step name ([77bf4ed](77bf4ed)) * reorder backup ([ab66486](ab66486)) * revert to v2 for semver ([535a721](535a721)) * Save active spec metadata ([47bd862](47bd862)) * Secret reading metadata ([6dab7ed](6dab7ed)) * secrets stored with correct values ([f6d61e9](f6d61e9)) * Serve console with gin ([c9e04aa](c9e04aa)) * set namespace when running kubectl apply ([1d6f00c](1d6f00c)) * Setting cached release namespace incorrectly ([e585555](e585555)) * Simplify docker image ([1cf55e4](1cf55e4)) * Support Openshift permissions schema for the helm cache ([wandb#17](https://github.com/sqaisar/wandb-operator/issues/17)) ([b498f79](b498f79)) * TLS ([wandb#67](https://github.com/sqaisar/wandb-operator/issues/67)) ([0d3013c](0d3013c)) * Tmp directory permissions ([b0820f5](b0820f5)) * Update to fix some CVEs ([wandb#55](https://github.com/sqaisar/wandb-operator/issues/55)) ([9a34cbe](9a34cbe)) * upgrade semantic to v3 ([594c463](594c463)) * Use cdk8s image for apply container ([189bc08](189bc08)) * Use deployer release channels ([480b380](480b380)) * Using validate for job spec ([5c7ff66](5c7ff66)) * x-kubernetes-preserve-unknown-fields ([bedac52](bedac52))
5 participants
Summary by CodeRabbit
New Features
Tests
RepoReleasestruct, covering various functionalities and error handling.Chores