fix(icons, input): icon vertical alignment and Addon size prop leaking#52
Merged
wangdicoder merged 5 commits intomasterfrom Mar 13, 2026
Merged
Conversation
InputGroupAddon.cloneElement was blindly passing size='md' to all children including icons, causing SVGs to render with width="md" instead of their default "1em". Now only clones props onto Input, Button, and Select children.
SVG icons defaulted to vertical-align: baseline, causing misalignment when used inline with text. Now all icons default to vertical-align: middle, which can still be overridden via the style prop.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloneElementblindly passingsize="md"to all children — icons received it as an SVG dimension, rendering oversized. Now only passessize/disabledto Input, Button, and Select children.vertical-align: middleas default style on all SVG icons so they align properly when used inline with text (instead of baseline).Test plan
<Addon><IconUser/></Addon>renders the icon at normal1emsize<Addon><Button>...</Button></Addon>still receives size/disabled props correctlystyleprop can still overrideverticalAlign🤖 Generated with Claude Code