fix(react): table selection bugs, list semantics, loader redesign, button fix#86
Merged
wangdicoder merged 5 commits intomasterfrom Mar 28, 2026
Merged
fix(react): table selection bugs, list semantics, loader redesign, button fix#86wangdicoder merged 5 commits intomasterfrom
wangdicoder merged 5 commits intomasterfrom
Conversation
…e types - Replace native <input> with Checkbox and Radio components for consistent styling - Fix pagination index bug where page-relative indices caused key collisions - Fix handleSelectRow filtering against unsorted dataSource - Add columns to defaultSortOrder effect dependency array - Use paginationConfig for proper type narrowing in handlePageChange - Constrain ColumnType.dataIndex to keyof T & string - Change RowSelection from type alias to interface - Remove unused fixed prop from ColumnType - Document missing props (rowClassName, onRow, defaultSortOrder, className)
…on icon shrink List: - Use semantic <ul>/<li> elements instead of <div> for list items - Add forwardRef to ListItemMeta - Extend ListItemMetaProps with div intrinsic props - Change ListItemProps to extend <li> intrinsic elements - Fix renderItem index to use global index when paginated - Add aria-busy, role="status", and aria-live attributes - Preserve generic type T through List export Loader: - Replace dot-based indicator with CSS-only spinning border animation - Remove 4 dot spans, use single div with ::before/::after pseudo-elements - Use CSS custom property --ty-loader-border-width for size variants - Simplify SCSS by removing size-specific nested selectors Button: - Add flex-shrink: 0 to icon container to prevent shrinking - Shorten loading demo button labels useVirtualScroll: - Add enabled option to skip scroll tracking when not in virtual mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Table
<input>withCheckboxandRadiocomponents for consistent stylinghandleSelectRowfiltering against unsorteddataSourceinstead ofsortedDatacolumnsdependency todefaultSortOrdereffectpaginationConfigfor proper type narrowing inhandlePageChangeColumnType.dataIndextokeyof T & stringRowSelectionfrom type alias to interface; remove unusedfixedproprowClassName,onRow,defaultSortOrder,classNameList
<ul>/<li>elements instead of<div>for list itemsforwardReftoListItemMeta; extend props with div intrinsic attributesrenderItemindex to use global index when paginatedaria-busy,role="status", andaria-liveattributesTthrough List exportLoader
<span>elements, use single<div>with::before/::after--ty-loader-border-widthfor size variantsButton
flex-shrink: 0to icon container to prevent shrinking in flex layoutuseVirtualScroll
enabledoption to skip scroll tracking when not in virtual modeRelease
@tiny-design/reactTest plan
<ul>/<li>in DOMpnpm test— all tests pass🤖 Generated with Claude Code