feat: IconButton 시안 정합 — NormalSize enum 도입 및 사이즈 토큰 갱신#485
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 28 minutes and 24 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
WalkthroughButton에 ChangesButton 및 IconButton 컴포넌트 확장
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Sources/Blueprint/Sources/Scene/Previews/IconButtonPreview.swift`:
- Line 16: The initial normalSizeIndex is set to 2 which maps to .large(20) but
the comment and intended default are 24px/.xlarge; update the `@State` property
normalSizeIndex in IconButtonPreview so its initial value matches the index that
corresponds to the .xlarge (24px) size and update the trailing comment to
reflect 24 as the default; locate the normalSizeIndex declaration to change its
numeric value and accompanying comment to the correct index for .xlarge.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 5a65aea1-a446-4eb7-a419-fe9d9873219c
📒 Files selected for processing (15)
Sources/Blueprint/Sources/Scene/Previews/ButtonPreview.swiftSources/Blueprint/Sources/Scene/Previews/IconButtonPreview.swiftSources/Blueprint/Sources/Scene/Previews/TextFieldPreview.swiftSources/Montage/1 Components/2 Actions/Button.swiftSources/Montage/1 Components/2 Actions/IconButton.swiftSources/Montage/1 Components/3 Selection And Input/Select.swiftSources/Montage/1 Components/3 Selection And Input/TextField.swiftSources/Montage/1 Components/4 Contents/Card.swiftSources/Montage/1 Components/6 Navigations/Category.swiftSources/Montage/1 Components/6 Navigations/Tab.swiftSources/Montage/1 Components/7 Feedback/SnackBar.swiftSources/Montage/1 Components/8 Presentation/Popover.swiftdocumentation/components/actions/button/ios.mddocumentation/components/actions/iconbutton/ios.mdpackages/montage-mcp/data/components.json
github-actions
Bot
added
accepted
knine79
force-pushed
the
feat/iconbutton-ui-update
branch
from
9634778 to
8fb44de
Compare
github-actions
Bot
added
in review
knine79
force-pushed
the
feat/iconbutton-ui-update
branch
from
8fb44de to
337acbb
Compare
knine79
added
accepted
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
수정사항
API breaking change
IconButton.Variant.normal(size: Int)→.normal(size: NormalSize)IconButton.NormalSizeenum.small(16) /.medium(18) /.large(20) /.xlarge(24) /.custom(size:).normal(size: .xlarge)(=24, 기존 동작 보존)Normal variant
Circle()RoundedRectangle(사이즈별 radius).labelDisable.opacity(0.16).labelDisable(시안 #37383C)Outlined / Solid variant
.smallicon.mediumicon.smallpadding.mediumpadding.custompadding.lineNeutral.lineNeutral.opacity(0.16).labelDisable.opacity(0.16).labelDisable호출처 마이그레이션
Tab/Category/Select/TextField/SnackBar/Card/Popover/TextFieldPreview모두 새NormalSizeenum 사용으로 갱신. 시안에 없는 픽셀값(8, 22)은.custom(size:)로 변환해 시각적 픽셀값 보존.Blueprint
IconButtonPreview의 normal size UI를[small][medium][large][xlarge][custom]SegmentedControl로 변경자동 생성
make로 DocC 및 MCP 데이터 갱신 (documentation/components/actions/iconbutton/ios.md,packages/montage-mcp/data/components.json)미리보기