Skip to content

Fix varnish version in images#482

Merged
davidalger merged 2 commits intodevelopfrom
fix-varnish-version-in-images
Feb 15, 2022
Merged

Fix varnish version in images#482
davidalger merged 2 commits intodevelopfrom
fix-varnish-version-in-images

Conversation

@davidalger
Copy link
Copy Markdown
Collaborator

See #480; this was a bug caused by Appstream pkg for varnish overriding the custom one from the Package Cloud repo with specific versions resulting in all the Varnish images having the default 4.0.x version from EL 8 rpms.

After these changes, the built images have the correct varnish versions once more:

$ docker run --rm -it wardenenv/varnish:6.5 varnishd -V
varnishd (varnish-6.5.2 revision e7233b0ad2639043341819d19a8d2e418e94ce1b)
Copyright (c) 2006 Verdens Gang AS
Copyright (c) 2006-2020 Varnish Software

$ docker run --rm -it wardenenv/varnish:6.4 varnishd -V
varnishd (varnish-6.4.0 revision 13f137934ec1cf14af66baf7896311115ee35598)
Copyright (c) 2006 Verdens Gang AS
Copyright (c) 2006-2020 Varnish Software AS

$ docker run --rm -it wardenenv/varnish:6.0 varnishd -V
varnishd (varnish-6.0.10 revision 9a7da4ff4c0c824af33e230740a11e99fdca23d9)
Copyright (c) 2006 Verdens Gang AS
Copyright (c) 2006-2021 Varnish Software

$ docker run --rm -it wardenenv/varnish:4.1 varnishd -V
varnishd (varnish-4.1.11 revision 61367ed17d08a9ef80a2d42dc84caef79cdeee7a)
Copyright (c) 2006 Verdens Gang AS
Copyright (c) 2006-2019 Varnish Software AS

@davidalger davidalger merged commit 5ea2501 into develop Feb 15, 2022
@davidalger davidalger deleted the fix-varnish-version-in-images branch February 15, 2022 16:15
@ihor-sviziev
Copy link
Copy Markdown
Contributor

@davidalger great! Thank you!

@ihor-sviziev
Copy link
Copy Markdown
Contributor

ihor-sviziev commented Feb 15, 2022

@davidalger I'd like to prepare arm versions of all the images (will start from varnish), based on what's available in this repo and in https://github.com/drpayyne/warden-multi-arch

So far everything is good preparing for varnish 6.0 and 6.5, but the versions 4.1 and 6.4 can't be built for some reason. So maybe better to just skip them for now. Will you accept it if I'll do a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants