ref: Add Client builder for generic abstraction#56
Merged
Callisto13 merged 1 commit intomainfrom Jun 28, 2022
Merged
Conversation
This adds a `ClientBuilderFunc` to the command Config option, and moves the create logic back into the `CreateFn` and out of the `client`. This gives a nicer abstraction layer for testing, as well as a smaller shim over the real flintlock client. There is more scope for refactoring the busier commands (eg `delete`), but this make things easier for now.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
ClientBuilderFuncto the command Config option, and movesthe create logic back into the
CreateFnand out of theclient.This gives a nicer abstraction layer for testing, as well as a smaller
shim over the real flintlock client.
There is more scope for refactoring the busier commands (eg
delete),but this make things easier for now.