Skip to content

Conversation

@VinayakVispute
Copy link
Contributor

Issue #118 πŸ“

Description πŸ”

In this pull request, I've made a specific change in pagination.jsx to address the following issues:

  • Updated the loading style for pagination componenets by added styling class named centreDiv .

The modified code in pagination.jsx is as follows :

**From : **

<Root className={classes.root}>
			{!isLoading && (
				<Paper className={`${classes.paperLight} ${mode === 'light' ? classes.paperLight : classes.paperDark}`} elevation={6}>
					<Pagination className={classes.pagination} classes={{ ul: classes.ul }} count={numberOfPages} page={Number(page) || 1} variant="outlined" color="primary" renderItem={(item) => <PaginationItem className={classes.eachPage} {...item} component={Link} to={`/posts?page=${item.page}`} />} />
				</Paper>
			)}
		</Root>

**To: **

<Paper className={`${classes.paperLight} ${mode === 'light' ? classes.paperLight : classes.paperDark}`} elevation={6}>
				{isLoading ? (
					<div className={`${classes.centerDiv}`}>
						<CircularProgress size="1rem" />
					</div>
				) : (
					<Pagination className={classes.pagination} classes={{ ul: classes.ul }} count={numberOfPages} page={Number(page) || 1} variant="outlined" color="primary" renderItem={(item) => <PaginationItem className={classes.eachPage} {...item} component={Link} to={`/posts?page=${item.page}`} />} />
				)}
			</Paper>
  1. Add this style class for centering the loading element :
	[`& .${classes.centerDiv}`]: {
		display: 'flex',
		justifyContent: 'center',
		alignItems: 'center',
	},

Guidelines πŸ”

I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

  • Contribution Guidelines
  • Code of Conduct

Issue to be closed πŸ›…

Screenshots πŸ“·

screen-capture.7.webm

@vercel
Copy link

vercel bot commented Oct 18, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @warmachine028 on Vercel.

@warmachine028 first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
memories βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 18, 2023 3:14pm
memories-server βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 18, 2023 3:14pm

@github-actions github-actions bot added hacktoberfest This issue/pull request is specially marked for hacktoberfest 🐞 bug Something isn't working πŸ›  goal: fix labels Oct 18, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @VinayakVispute, thank you for raising a pull request.

Please make sure you have filled the PR template properly and followed our contributing guidelines.

@VinayakVispute
Copy link
Contributor Author

@warmachine028 Buddy Please Review the PR

@warmachine028 warmachine028 changed the title fix : Pagination Loading Style Updated fix : pagination loading style updated Oct 18, 2023
@warmachine028 warmachine028 changed the title fix : pagination loading style updated fix: pagination loading style updated Oct 18, 2023
@warmachine028 warmachine028 merged commit 86683fe into warmachine028:main Oct 18, 2023
@warmachine028 warmachine028 added the hacktoberfest-accepted The contribution was accepted for hactoberfest label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working πŸ›  goal: fix hacktoberfest This issue/pull request is specially marked for hacktoberfest hacktoberfest-accepted The contribution was accepted for hactoberfest

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG 🐞] Implement Loading Component to Enhance Page Refresh Experience β³πŸ”

2 participants