[Fixed-#52]: Added animation/transition in Mode Toggle Switch in Navb…

[avinasdube]

Issue #52 📐

• I Avinash Dubey (@avinasdube) have worked for [FEATURE] Animation in Theme toggle Button #52

Guidelines 🔐

I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

• Contribution Guidelines
• Code of Conduct

Issue to be closed 🛅

• My pull request closes [FEATURE] Animation in Theme toggle Button #52

NOTE :

• Above changes do not apply to the Floating Navbar. I have tried my best to fix it but I couldn't. I suggest you to look into it before merging and if you can please fix it as you have access to further edit changes. I think the issue is with MUI Styled Components (maybe). Otherwise, merge it for now and create a new issue for the Floating Navbar Problem, and I'm also trying to fix it. If I find a solution, I'll fix it myself.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
memories	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 2:32pm
memories-server	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 24, 2023 2:32pm

[vercel]

Someone is attempting to deploy a commit to a Personal Account owned by @warmachine028 on Vercel.

@warmachine028 first needs to authorize it.

[warmachine028]

Please merge the latest changes in your branch, to update it.
It was mentioned clearly in the issue comment.

Just make sure to update your branch with the latest changes. I have made slight changes after the PR was merged.

This is causing the merge conflict.

[avinasdube]

Oh...sorry ! I did update but forgot to merge changes. I'll do it again and then make the PR.

[warmachine028]

I will have to resolve these merge conflicts, it will take some time

[warmachine028]

Great work on the animation part. I will be merging it soon!

Above changes do not apply to the Floating Navbar. I have tried my best to fix it, but I couldn't. I suggest you look into it before merging and if you can please fix it as you have access to further edit changes. I think the issue is with MUI Styled Components (maybe). Otherwise, merge it for now and create a new issue for the Floating Navbar Problem, and I'm also trying to fix it. If I find a solution, I'll fix it myself.

• I believe it is enough work for one issue.
• The bug in the Floating navbar can be further fixed by creating a separate issue.

[avinasdube]

Great work on the animation part. I will be merging it soon!

Above changes do not apply to the Floating Navbar. I have tried my best to fix it, but I couldn't. I suggest you look into it before merging and if you can please fix it as you have access to further edit changes. I think the issue is with MUI Styled Components (maybe). Otherwise, merge it for now and create a new issue for the Floating Navbar Problem, and I'm also trying to fix it. If I find a solution, I'll fix it myself.

• I believe it is enough work for one issue.
• The bug in the Floating navbar can be further fixed by creating a separate issue.

Thanks. I think simple animations are best instead of very fancy ones. I could have done more fancy but my "inner designer" 😄 wasn't allowing me to do so. So, I did the simple but beautiful one. And definitely create a new issue for the Floating Navbar problem. If I can't, then someone else would definitely do it.

[warmachine028]

Good news!🎊🎊🎊. I have fixed the issue with the animation in Floating Navbar. I will be pushing the updated code soon.

[avinasdube]

Good news!🎊🎊🎊. I have fixed the issue with the animation in Floating Navbar. I will be pushing the updated code soon.

That's great. Thanks to you, I too got my very first badge on github for 2 PRs merged. 😍