docs: fix nav bar icons and spacing#33
Merged
rachaelrenk merged 3 commits intomainfrom May 8, 2026
Merged
Conversation
- Guides: puzzle → rocket (was duplicate of Agents icon) - Enterprise: star → setting (better conveys admin/governance) - Nav links: double horizontal padding (0.125rem → 0.25rem) for better click targets and breathing room Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hongyi-chen
approved these changes
May 8, 2026
hongyi-chen
reviewed
May 8, 2026
| icon: 'star', | ||
| label: 'Enterprise', | ||
| link: '/enterprise/', | ||
| icon: 'setting', |
Collaborator
There was a problem hiding this comment.
I'm not sure if setting is the right icon here, are there any other icons that might work? I don't feel too strongly, idk if there's an office building icon or something like that lol
Contributor
Author
There was a problem hiding this comment.
Added a custom SVG of a simple building!
hongyi-chen
approved these changes
May 8, 2026
Add an office building inline SVG for the Enterprise topic in WarpTopicNav.astro, replacing the gear icon per review feedback. The building has a simple outline with window dots and entrance, stroke-matched to the other custom icons (robot, brackets). sidebar.ts keeps star as the mobile drawer fallback since custom SVGs can't be used in the starlight-sidebar-topics plugin. Co-Authored-By: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix duplicate and unfitting icons in the top nav bar, and improve link spacing for better readability and click targets.
Changes
src/sidebar.tspuzzletorocket-- Guides and Agents were both usingpuzzle, making them visually indistinguishable.rocketconveys "tutorials / getting started" and is unique across the nav.startosetting--staris generic and doesn't convey "enterprise admin/governance."setting(gear icon) is the convention for admin surfaces.src/components/WarpTopicNav.astro0.125remto0.25rem) for better click targets and breathing room between items.Note on icon visibility
The icon changes in
sidebar.tsare not visible at most viewport widths.WarpTopicNav.astrohides icons below 80rem (1280px) via a media query, so with 8 topics most users' screens trigger this breakpoint.The icon changes still apply to:
starlight-sidebar-topicsplugin renders its own icon set fromsidebar.ts, which is always visible in the mobile menuContext
Part of the docs v2 bug bash follow-up work. Tracks to Notion item: Migration FF: nav bar polish.
Co-Authored-By: Oz oz-agent@warp.dev