let docker client take care of image cache#11
Merged
Conversation
acarl005
changed the title
acarl005
commented
Feb 3, 2026
|
|
||
| // pullImage pulls a Docker image. If authStr is non-empty, it will be used for registry authentication. | ||
| // Docker only downloads changed layers, so this is efficient even if the image exists locally. | ||
| func (w *Worker) pullImage(ctx context.Context, imageName string, authStr string) error { |
Collaborator
Author
There was a problem hiding this comment.
Now that pulling the sidecar and the main environment image are the exact same operation, move this into a reusable function.
ianhodge
approved these changes
Feb 3, 2026
Member
ianhodge
left a comment
ianhodge
left a comment
There was a problem hiding this comment.
don't have a ton of context on this code but this overall makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the sidecar image, we were doing a manual call to
ImageInspectand then only callingImagePullif the image wasn't present. This was a temporary workaround which is not longer necessary now that the sidecar image is public.