Use server-side task resolution instead of passing prompt to CLI#14
Merged
johnturcoo merged 2 commits intomainfrom Feb 3, 2026
Merged
Use server-side task resolution instead of passing prompt to CLI#14johnturcoo merged 2 commits intomainfrom
johnturcoo merged 2 commits intomainfrom
Conversation
Collaborator
|
Great catch. Thanks for fixing. Looks like this got out of sync with the warp-hosted workers. We definitely need to figure out a solution for keeping this stuff in sync. |
acarl005
reviewed
Feb 3, 2026
| "--task-id", | ||
| task.ID, | ||
| "--prompt", | ||
| common.EffectivePromptForTask(task), |
Collaborator
There was a problem hiding this comment.
Is this function unused now?
Contributor
Author
There was a problem hiding this comment.
Yes, just updated the PR!
acarl005
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
--promptto align with the Namespace worker behavior. If we pass--promptand--task-idto the CLI it results in skipping the server-side resolution and never attach images as context.