name sidecar volumes based on image hash instead of tag#15
Merged
Conversation
bnavetta
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where a stale version of the Warp CLI would run.
We don't have the Namespace concept of a "sidecar volume" in the self-hosted workers. Instead, we need to manually build a volume from the sidecar container's filesystem and mount that into each task's container. That's a lot of work, so we try to only build that volume when it is actually necessary. Before building it, we use
VolumeInspectto check if the volume exists and if not, callVolumeCreate. How effective this is depends on the naming scheme for the volume.Unfortunately, the naming was off. I named it based on the image name + tag (e.g.
warpdotdev-warp-agent-latest-dev). When we update a tag, it would not realize that the volume needs to be updated. In this PR, I change the naming scheme to be based on the has which fixes the issue (e.g.warpdotdev-warp-agent-5b7279537a55).