Skip to content

spec: configurable code editor line number modes#10012

Open
oz-for-oss[bot] wants to merge 3 commits intomasterfrom
oz-agent/spec-issue-9816
Open

spec: configurable code editor line number modes#10012
oz-for-oss[bot] wants to merge 3 commits intomasterfrom
oz-agent/spec-issue-9816

Conversation

@oz-for-oss
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot commented May 4, 2026

Summary

  • Add a product spec for configurable Absolute, Relative, and Hybrid code editor line numbering modes.
  • Add a tech spec grounding the implementation in AppEditorSettings, the Settings > Text Editing UI, and the CodeEditorView/EditorWrapper gutter rendering path.
  • Scope terminal input, AI input, and notebook editors out because they do not currently render line-number gutters.

Validation

  • Spec-only change; reviewed generated product and tech spec contents.

Related issue: #9816

Co-Authored-By: Oz <oz-agent@warp.dev>

Co-Authored-By: Narley Brittes <narley@users.noreply.github.com>
@oz-for-oss
Copy link
Copy Markdown
Contributor Author

oz-for-oss Bot commented May 4, 2026

@oz-for-oss[bot]

I'm starting a first review of this spec-only pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor Author

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

The specs define product behavior and a concrete implementation approach for Absolute, Relative, and Hybrid code editor line-number modes, covering persistence, settings UI placement, gutter rendering, diff/review behavior, and excluded editor surfaces.

Concerns

  • The tech spec is internally inconsistent about telemetry: it requires adding telemetry mapping for the settings action while later stating the spec does not require new telemetry.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Comment thread specs/GH9816/tech.md Outdated
Comment thread specs/GH9816/product.md Outdated
Comment thread specs/GH9816/product.md Outdated
oz-agent and others added 2 commits May 5, 2026 16:48
Co-Authored-By: Narley Brittes <narley@users.noreply.github.com>

Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Narley Brittes <narley@users.noreply.github.com>
@narley
Copy link
Copy Markdown

narley commented May 7, 2026

@oz-agent start implementation

@oz-for-oss
Copy link
Copy Markdown
Contributor Author

oz-for-oss Bot commented May 7, 2026

@narley

I ran into an unexpected error while working on this.

Powered by Oz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants