spec: configurable code editor line number modes#10012
spec: configurable code editor line number modes#10012oz-for-oss[bot] wants to merge 3 commits intomasterfrom
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev> Co-Authored-By: Narley Brittes <narley@users.noreply.github.com>
|
@oz-for-oss[bot] I'm starting a first review of this spec-only pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
The specs define product behavior and a concrete implementation approach for Absolute, Relative, and Hybrid code editor line-number modes, covering persistence, settings UI placement, gutter rendering, diff/review behavior, and excluded editor surfaces.
Concerns
- The tech spec is internally inconsistent about telemetry: it requires adding telemetry mapping for the settings action while later stating the spec does not require new telemetry.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Co-Authored-By: Narley Brittes <narley@users.noreply.github.com> Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Narley Brittes <narley@users.noreply.github.com>
|
@oz-agent start implementation |
Summary
Validation
Related issue: #9816