Skip to content

fix(deb): respect apt Deb822 source files#10021

Closed
jbetala7 wants to merge 1 commit intowarpdotdev:masterfrom
jbetala7:fix/apt-modernize-sources-10011
Closed

fix(deb): respect apt Deb822 source files#10021
jbetala7 wants to merge 1 commit intowarpdotdev:masterfrom
jbetala7:fix/apt-modernize-sources-10011

Conversation

@jbetala7
Copy link
Copy Markdown

@jbetala7 jbetala7 commented May 4, 2026

Description

Fixes #10011.

When Ubuntu's apt modernize-sources converts warpdotdev.list to the Deb822 warpdotdev.sources format, a later package postinst run sees that warpdotdev.list is missing and recreates it. That leaves both files configured for the same repo and causes duplicate-source warnings during apt update.

This change treats an existing @@REPO_NAME@@.sources file as an already-configured repo source. If a stale legacy .list file is present alongside it, postinst removes the .list file so the Deb822 source remains the single source of truth. On purge, postrm now removes both .list and .sources formats.

Linked Issue

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). N/A; packaging script change.

Testing

  • sh -n resources/linux/debian/common/postinst.repo.template
  • sh -n resources/linux/debian/common/postrm.repo.template
  • bash -n script/linux/bundle_deb
  • git diff --check
  • Simulated postinst with fake apt-config: existing warpdotdev.sources plus stale warpdotdev.list keeps .sources and removes .list; fresh state with neither source creates .list as before.
  • Simulated generated postrm purge with fake apt-config: removes signing key, .list, and .sources.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 4, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jbetala7 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 4, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 4, 2026

@jbetala7

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @acarl005.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR updates the Debian package scripts so post-install recognizes an existing Deb822 @@REPO_NAME@@.sources file, removes a stale duplicate .list file when Deb822 is present, and removes both source formats during purge.

Concerns

  • No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested a review from acarl005 May 4, 2026 08:21
@acarl005
Copy link
Copy Markdown
Contributor

acarl005 commented May 7, 2026

Thanks for the fix. Closing this in favor of #10019

@acarl005 acarl005 closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate APT source entries created (.list and .sources) causing warnings on apt update

2 participants