fix(deb): respect apt Deb822 source files#10021
fix(deb): respect apt Deb822 source files#10021jbetala7 wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jbetala7 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @acarl005. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR updates the Debian package scripts so post-install recognizes an existing Deb822 @@REPO_NAME@@.sources file, removes a stale duplicate .list file when Deb822 is present, and removes both source formats during purge.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
Thanks for the fix. Closing this in favor of #10019 |
Description
Fixes #10011.
When Ubuntu's
apt modernize-sourcesconvertswarpdotdev.listto the Deb822warpdotdev.sourcesformat, a later packagepostinstrun sees thatwarpdotdev.listis missing and recreates it. That leaves both files configured for the same repo and causes duplicate-source warnings duringapt update.This change treats an existing
@@REPO_NAME@@.sourcesfile as an already-configured repo source. If a stale legacy.listfile is present alongside it,postinstremoves the.listfile so the Deb822 source remains the single source of truth. On purge,postrmnow removes both.listand.sourcesformats.Linked Issue
ready-to-specorready-to-implement.Testing
sh -n resources/linux/debian/common/postinst.repo.templatesh -n resources/linux/debian/common/postrm.repo.templatebash -n script/linux/bundle_debgit diff --checkpostinstwith fakeapt-config: existingwarpdotdev.sourcesplus stalewarpdotdev.listkeeps.sourcesand removes.list; fresh state with neither source creates.listas before.postrm purgewith fakeapt-config: removes signing key,.list, and.sources.Agent Mode