Mark focused-pane notifications as read when the warp window is re-focused#10082
Open
harryalbert wants to merge 2 commits intomasterfrom
Open
Mark focused-pane notifications as read when the warp window is re-focused#10082harryalbert wants to merge 2 commits intomasterfrom
harryalbert wants to merge 2 commits intomasterfrom
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
harryalbert
force-pushed
the
oz-agent/WAR-7383-notification-dot-window-focus
branch
from
5fd3bba to
ebc19eb
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds a window-state handler path that clears focused terminal notifications when Warp becomes active again, in addition to existing focus changes.
Concerns
- App reactivation can run before the async active-window update has replaced the previously active Warp window, so notifications may be marked read in the wrong window when the user returns by clicking a different Warp window.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
changed the title
zachbai
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the user shifts focus from one pane to another pane, we mark the notifications in that pane as read. We should do the same when a user shifts focus from a different app back into warp (for the pane that is then focused).
Demo
https://www.loom.com/share/343ab3ee8358495686e0dc30c4d4ba2a
Linear: WAR-7383
This PR was created by Oz (running Codex).