Select new default when a model is disabled#10085
Conversation
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds disabled-model preference reconciliation so stored profile model selections are cleared when the selected model is no longer usable.
Concerns
RequiresUpgradeusability now depends on the user's current BYOK key state, but reconciliation only runs when model choices are refreshed. Removing/disabling a provider key can leave the stored disabled model selected until another model-list update occurs.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| /// and not effectively disabled for the current user). | ||
| fn usable_info_for_id(&self, id: &LLMId, app: &AppContext) -> Option<&LLMInfo> { | ||
| self.info_for_id(id).filter(|info| { | ||
| let has_byok_key = is_using_api_key_for_provider(&info.provider, app); |
There was a problem hiding this comment.
RequiresUpgrade usability now depends on the current BYOK key state, but this cleanup only runs on model-list updates. If the user removes or disables the provider key after keeping this preference, the stored disabled model remains selected until another model refresh; rerun this reconciliation on ApiKeyManagerEvent::KeysUpdated or apply usable_info_for_id in the active-model fallback.
2 participants
Description
We have some logic for selecting a new default model if the user's current model is no longer available. However, this logic doesn't account when a model is disabled, which is different from when a model is removed.
This fixes our logic to account for model disablement.
Linked Issue
ready-to-specorready-to-implement.Screenshots / Videos
Testing
Tested locally, verified that it works.
Agent Mode