use correct cloud agent icons for 3p conversation transcripts#10148
Merged
harryalbert merged 2 commits intomasterfrom May 5, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR updates agent icon resolution so third-party cloud conversation transcripts can use server/task harness metadata across the conversation list, vertical tabs, and pane header.
Concerns
- The terminal icon path still misses CLI-agent transcripts opened through the loading-pane replacement flow because that restoration path does not preserve the transcript's ambient task id on the new terminal model.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
liliwilson
approved these changes
May 5, 2026
harryalbert
deleted the
harry/app-4377-fix-issue-with-missing-3rd-party-agent-branding-in-restored
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We weren't properly checking/respecting 3p agent harness information for cloud conversation transcripts when deciding which icon to display in the conversation list, vertical tabs, and pane header.
Screenshots / Videos
Agent Mode