Forward CLI agent env vars into WSL#10174
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @gabrimatic on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment |
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
There was a problem hiding this comment.
Overview
This PR forwards the Warp client version and, when HOA notifications are enabled, the CLI agent protocol version through WSLENV so WSL shells receive the notification-related environment needed by CLI agents. It also extracts the WSLENV construction into a helper and adds regression coverage for the feature-flag-disabled and enabled cases.
Concerns
- None. The added WSLENV entries correspond to non-secret metadata already inserted into the shell environment, and the feature-flag gating for the protocol version remains consistent with the variable injection.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
Description
Fixes WSL sessions not receiving the environment variables needed for structured CLI agent notifications. The WSLENV allowlist now forwards WARP_CLIENT_VERSION and, when HOA notifications are enabled, WARP_CLI_AGENT_PROTOCOL_VERSION into WSL.
This also extracts the WSLENV construction into a small helper and adds regression coverage for the notification flag disabled/enabled cases.
Linked Issue
Fixes #10147
Testing
Changelog Entries for Stable
CHANGELOG-BUG-FIX: Fixed CLI agent notifications in WSL sessions by forwarding the required Warp environment variables into WSL.