Skip to content

Forward CLI agent env vars into WSL#10174

Merged
captainsafia merged 1 commit into
warpdotdev:masterfrom
gabrimatic:gabrimatic/wsl-cli-agent-env
May 8, 2026
Merged

Forward CLI agent env vars into WSL#10174
captainsafia merged 1 commit into
warpdotdev:masterfrom
gabrimatic:gabrimatic/wsl-cli-agent-env

Conversation

@gabrimatic
Copy link
Copy Markdown
Contributor

Description

Fixes WSL sessions not receiving the environment variables needed for structured CLI agent notifications. The WSLENV allowlist now forwards WARP_CLIENT_VERSION and, when HOA notifications are enabled, WARP_CLI_AGENT_PROTOCOL_VERSION into WSL.

This also extracts the WSLENV construction into a small helper and adds regression coverage for the notification flag disabled/enabled cases.

Linked Issue

Fixes #10147

  • This is a triaged bug report, which CONTRIBUTING.md treats as implicitly ready-to-implement.
  • No screenshots or video needed; this is an environment propagation fix with no UI surface.

Testing

  • cargo fmt -- --check
  • git diff --check
  • find . -name "*.wgsl" -exec wgslfmt --check {} +
  • cargo clippy -p warp --lib --all-features -- -D warnings
  • cargo check -p warp --lib --target x86_64-pc-windows-gnu --tests
  • ./script/presubmit was started and passed cargo fmt, both clippy passes, and clang-format before stopping because wgslfmt was not installed locally. After installing the repo-pinned wgslfmt, the WGSL formatting check above passed.

Changelog Entries for Stable

CHANGELOG-BUG-FIX: Fixed CLI agent notifications in WSL sessions by forwarding the required Warp environment variables into WSL.

@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 5, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @gabrimatic on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

@github-actions github-actions Bot added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label May 5, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 5, 2026

@gabrimatic

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @warpdotdev/oss-maintainers.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@gabrimatic
Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label May 5, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot Bot commented May 5, 2026

The cla-bot has been summoned, and re-checked this pull request!

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR forwards the Warp client version and, when HOA notifications are enabled, the CLI agent protocol version through WSLENV so WSL shells receive the notification-related environment needed by CLI agents. It also extracts the WSLENV construction into a helper and adds regression coverage for the feature-flag-disabled and enabled cases.

Concerns

  • None. The added WSLENV entries correspond to non-secret metadata already inserted into the shell environment, and the feature-flag gating for the protocol version remains consistent with the variable injection.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot requested review from a team and zachbai and removed request for a team May 5, 2026 19:18
@zachbai zachbai requested review from acarl005 and removed request for zachbai May 8, 2026 04:20
Copy link
Copy Markdown
Contributor

@zachbai zachbai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tagging @acarl005 for this one

Copy link
Copy Markdown
Contributor

@acarl005 acarl005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@acarl005 acarl005 self-assigned this May 8, 2026
@captainsafia captainsafia merged commit 22c9472 into warpdotdev:master May 8, 2026
30 checks passed
trungtai1805 pushed a commit to trungtai1805/warp that referenced this pull request May 9, 2026
tungd pushed a commit to tungd/warp that referenced this pull request May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Claude Code mailbox stays empty on WSL because plugin falls back to legacy OSC 777 notifications

4 participants