Reserve titlebar space for right-side window controls#10178
Conversation
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR reserves right-side titlebar control space whenever window controls are on the right, and adds unit coverage for the helper that decides whether tab-bar space should be reserved.
Concerns
- This is a user-visible titlebar layout change, but the PR does not include screenshots or a video showing the Windows/Linux titlebar spacing. For faster review, please upload screenshots or a video of the feature working end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR changes tab-bar layout so right-side custom window controls always reserve space while left-side controls retain the existing behavior, with direct unit coverage for the new helper.
Concerns
- This is a user-visible titlebar layout change, but the PR does not include screenshots or a short video. For faster review, please upload screenshots or a video showing the Windows/Linux titlebar controls and toolbar controls no longer overlap end to end.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
gabrimatic
force-pushed
the
gabrimatic/resource-center-titlebar-spacing
branch
from
85819bc to
15c72e7
Compare
|
@oz-for-oss I checked the current review state. The remaining blocker is the requested Windows/Linux screenshot or short video for the titlebar spacing change. I only have macOS available in this environment, so I am leaving that evidence gap open rather than substituting a macOS capture. I will add the requested Windows/Linux visual proof when I can capture it on the target platforms. |
|
@oz-for-oss I added the requested Linux visual evidence to the PR body. Screenshot: This was captured from a Linux container/Xvfb run of the built Additional Linux verification:
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
oz-for-oss
Bot
dismissed stale reviews from themself
Oz no longer requests changes for this pull request after the latest automated review.
There was a problem hiding this comment.
Overview
This PR updates the tab-bar titlebar spacer so right-side custom window controls always reserve space, preventing toolbar controls from overlapping Windows/Linux traffic-light controls while preserving left-side behavior. It also adds direct coverage for the new reservation predicate.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
oz-for-oss
Bot
requested review from
a team and
captainsafia
and removed request for
a team
captainsafia
left a comment
captainsafia
left a comment
There was a problem hiding this comment.
The change to the source file seems sensible but the the changes to the test files need some work. I left comments inline.
gabrimatic
force-pushed
the
gabrimatic/resource-center-titlebar-spacing
branch
from
b1fab78 to
cfad1d7
Compare
## Description - Always reserve right-side titlebar control space in the tab bar when custom window controls are on the right. - Keeps the Resource Center / What's New toolbar controls out from underneath Windows/Linux close, minimize, and maximize controls while preserving left-side macOS behavior. ## Linked Issue - Fixes #10139 - [x] The linked issue is labeled `ready-to-implement`. - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). ## Screenshots / Videos Linux Xvfb run of `warp-oss`:  Short video: [pr10178-linux-titlebar.mp4](https://raw.githubusercontent.com/gabrimatic/warp/pr-10178-linux-evidence/evidence/pr-10178/pr10178-linux-titlebar.mp4) ## Testing - `cargo test -p warp traffic_light` - `cargo fmt -- --check` - `git diff --check` - `cargo check -p warp --lib --target x86_64-pc-windows-gnu --tests` - `cargo clippy -p warp --lib --all-features -- -D warnings` - Linux container: `cargo test -p warp traffic_light -- --nocapture` - Linux container: `cargo build -p warp --bin warp-oss --features gui,fast_dev -j1` - Linux Xvfb capture of the built `warp-oss` binary
## Description - Always reserve right-side titlebar control space in the tab bar when custom window controls are on the right. - Keeps the Resource Center / What's New toolbar controls out from underneath Windows/Linux close, minimize, and maximize controls while preserving left-side macOS behavior. ## Linked Issue - Fixes #10139 - [x] The linked issue is labeled `ready-to-implement`. - [x] Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes). ## Screenshots / Videos Linux Xvfb run of `warp-oss`:  Short video: [pr10178-linux-titlebar.mp4](https://raw.githubusercontent.com/gabrimatic/warp/pr-10178-linux-evidence/evidence/pr-10178/pr10178-linux-titlebar.mp4) ## Testing - `cargo test -p warp traffic_light` - `cargo fmt -- --check` - `git diff --check` - `cargo check -p warp --lib --target x86_64-pc-windows-gnu --tests` - `cargo clippy -p warp --lib --all-features -- -D warnings` - Linux container: `cargo test -p warp traffic_light -- --nocapture` - Linux container: `cargo build -p warp --bin warp-oss --features gui,fast_dev -j1` - Linux Xvfb capture of the built `warp-oss` binary
2 participants
Description
Linked Issue
ready-to-implement.Screenshots / Videos
Linux Xvfb run of
warp-oss:Short video: pr10178-linux-titlebar.mp4
Testing
cargo test -p warp traffic_lightcargo fmt -- --checkgit diff --checkcargo check -p warp --lib --target x86_64-pc-windows-gnu --testscargo clippy -p warp --lib --all-features -- -D warningscargo test -p warp traffic_light -- --nocapturecargo build -p warp --bin warp-oss --features gui,fast_dev -j1warp-ossbinary