Send context (skills, env) with /compact summarization requests#10274
Merged
Conversation
The SummarizeConversation input variant did not carry an AIAgentContext, so /compact requests were sent to the server with context: None. This meant the server had no skills list, execution environment, or other context data on the summarization request. Add a context field to SummarizeConversation, wire it through the slash command handler, API conversion, and secret redaction paths. QUALITY-615 Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR threads AIAgentContext through SummarizeConversation so /compact summarization requests include the same context data as other slash-command requests, and updates API conversion plus secret redaction accordingly.
Concerns
- No blocking correctness, security, or error-handling concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
harryalbert
approved these changes
May 6, 2026
trungtai1805
pushed a commit
to trungtai1805/warp
that referenced
this pull request
May 9, 2026
…dotdev#10274) ## Description The `SummarizeConversation` input variant did not carry `AIAgentContext`, so `/compact` requests were sent to the server with `context: None`. This meant the server received no skills list, execution environment, codebases, or other context data on summarization requests. Adds a `context` field to `SummarizeConversation`, wires it through the slash command handler, API conversion, and secret redaction paths. The context is now populated from the same `input_context_for_request` call that all other slash commands use. ## Linked Issue [QUALITY-615](https://linear.app/warpdotdev/issue/QUALITY-615/summarization-elides-available-skills-and-external-context) - [x] The linked issue is labeled `ready-to-spec` or `ready-to-implement`. ## Testing - [x] `cargo check` passes - [x] All existing match arms use `..` patterns that cover the new field (verified by compilation) - [x] Verified the three explicit destructure sites (convert_to.rs, redaction.rs, slash_command.rs) correctly handle the new field Companion server PR: warpdotdev/warp-server#10919 ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode [Conversation](https://staging.warp.dev/conversation/38229205-9edd-4787-883a-c775cebeaeb8) Co-Authored-By: Oz <oz-agent@warp.dev> Co-authored-by: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
SummarizeConversationinput variant did not carryAIAgentContext, so/compactrequests were sent to the server withcontext: None. This meant the server received no skills list, execution environment, codebases, or other context data on summarization requests.Adds a
contextfield toSummarizeConversation, wires it through the slash command handler, API conversion, and secret redaction paths. The context is now populated from the sameinput_context_for_requestcall that all other slash commands use.Linked Issue
QUALITY-615
ready-to-specorready-to-implement.Testing
cargo checkpasses..patterns that cover the new field (verified by compilation)Companion server PR: https://github.com/warpdotdev/warp-server/pull/10919
Agent Mode
Conversation
Co-Authored-By: Oz oz-agent@warp.dev