Promote DirectoryTabColors to Stable#10284
Merged
Merged
Conversation
Add directory_tab_colors to default features in app/Cargo.toml and remove from DOGFOOD_FLAGS. The enabled_features() bridge in app/src/lib.rs already has the cfg entry. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
zachbai
approved these changes
May 6, 2026
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR promotes DirectoryTabColors by enabling the Cargo feature in the default app feature set and removing the runtime flag from dogfood-only defaults.
Concerns
- No blocking correctness or security concerns found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
silveimar
pushed a commit
to silveimar/warp-dev
that referenced
this pull request
May 6, 2026
…otdev#9328) ## Description [APP-3805](https://linear.app/warpdotdev/issue/APP-3805/client-server-version-skew) — handle client/server version skew for the SSH remote-server binary. Previously the remote binary lived at a single unversioned path. When a client updated but the remote still had an older binary, the two could silently go out of sync. This PR does three things: 1. **Version the installed path.** The binary is now written to `{dir}/{binary_name}-{version}`, so any client-server drift becomes a path miss and triggers a reinstall. The unversioned path is kept for `cargo run` / `deploy_remote_server` dev loops. 2. **Check versions on handshake.** `initialize()` now compares `server_version` against the client's release tag. On mismatch, the manager deletes the stale binary, tears the session down, and emits `SessionConnectionFailed` so the failed-banner path fires. 3. **Auto-update without a prompt.** When `check_binary()` misses but the remote already has an install directory, we skip the "Install Warp SSH tools?" modal and install directly with `is_update: true`. The shimmer reads "Updating Warp SSH Extension..." instead of "Installing...". Dev clients without a release tag fall through to the normal prompt so they don't accidentally CDN-install over a locally-deployed binary. ## Testing - `cargo test -p remote_server`, `cargo clippy -D warnings`, `cargo fmt` — all clean. - Manual against `alokedesai@136.107.29.130`: - Fresh install: modal → "Installing Warp SSH Extension..." → Ready. - Reconnect with a newer client tag: handshake mismatch detected, stale binary removed, reconnect reinstalls. - Reconnect with an older client tag while a newer versioned binary is on the remote: auto-update, no modal, "Updating..." shimmer. - Forced install failure on the update path: failed banner renders. ## Server API dependencies None — warp-server already supports `?version=` on `/download/cli` (warpdotdev#10284). --------- Co-authored-by: Oz <oz-agent@warp.dev>
trungtai1805
pushed a commit
to trungtai1805/warp
that referenced
this pull request
May 9, 2026
## Description WISOTT. We should've released this a while ago but it fell off my radar. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NEW-FEATURE: You can now associate colors with directories so tabs automatically adopt the configured color when their working directory matches. Configure in Settings > Appearance. _Conversation: https://staging.warp.dev/conversation/d05ec6ff-9581-424a-9e58-e64425cc5985_ _Run: https://oz.staging.warp.dev/runs/019dfe93-b731-7c79-a492-37edf6efcc61_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <oz-agent@warp.dev>
1 task
zhangyu1818-bot
pushed a commit
to zhangyu1818/warply
that referenced
this pull request
May 10, 2026
WISOTT. We should've released this a while ago but it fell off my radar. - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode CHANGELOG-NEW-FEATURE: You can now associate colors with directories so tabs automatically adopt the configured color when their working directory matches. Configure in Settings > Appearance. _Conversation: https://staging.warp.dev/conversation/d05ec6ff-9581-424a-9e58-e64425cc5985_ _Run: https://oz.staging.warp.dev/runs/019dfe93-b731-7c79-a492-37edf6efcc61_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <oz-agent@warp.dev> (cherry picked from commit 782058a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WISOTT. We should've released this a while ago but it fell off my radar.
Agent Mode
CHANGELOG-NEW-FEATURE: You can now associate colors with directories so tabs automatically adopt the configured color when their working directory matches. Configure in Settings > Appearance.
Conversation: https://staging.warp.dev/conversation/d05ec6ff-9581-424a-9e58-e64425cc5985
Run: https://oz.staging.warp.dev/runs/019dfe93-b731-7c79-a492-37edf6efcc61
This PR was generated with Oz.