Skip to content

Hide notification chip in ambient sessions#10299

Merged
harryalbert merged 1 commit into
masterfrom
oz-agent/REMOTE-1586-hide-notification-chip-ambient
May 6, 2026
Merged

Hide notification chip in ambient sessions#10299
harryalbert merged 1 commit into
masterfrom
oz-agent/REMOTE-1586-hide-notification-chip-ambient

Conversation

@harryalbert
Copy link
Copy Markdown
Contributor

@harryalbert harryalbert commented May 6, 2026

Summary

We shouldn't show the plugin installation chip on Oz runs (doesn't make sense to install the plugin over a shared session or in an ambient agent run).

Tests

image

This PR was created by Oz (running Codex).

@cla-bot cla-bot Bot added the cla-signed label May 6, 2026
@harryalbert harryalbert requested a review from liliwilson May 6, 2026 20:28
@harryalbert harryalbert marked this pull request as ready for review May 6, 2026 20:28
Co-Authored-By: Oz <oz-agent@warp.dev>
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented May 6, 2026

@harryalbert

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@harryalbert harryalbert force-pushed the oz-agent/REMOTE-1586-hide-notification-chip-ambient branch from f14c8cc to bdfe0f6 Compare May 6, 2026 20:28
Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR hides the plugin notification chip when the terminal model represents a shared ambient agent session while preserving the CLI agent footer itself, with a regression test covering the shared cloud-agent viewer case.

Concerns

  • None.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@liliwilson liliwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar

@harryalbert harryalbert changed the title REMOTE-1586 Hide notification chip in ambient sessions c May 6, 2026
@harryalbert harryalbert changed the title c REMOTE-1586 Hide notification chip in ambient sessions May 6, 2026
@harryalbert harryalbert changed the title REMOTE-1586 Hide notification chip in ambient sessions Hide notification chip in ambient sessions May 6, 2026
@harryalbert harryalbert enabled auto-merge (squash) May 6, 2026 20:44
@harryalbert harryalbert merged commit 9e76f63 into master May 6, 2026
42 checks passed
@harryalbert harryalbert deleted the oz-agent/REMOTE-1586-hide-notification-chip-ambient branch May 6, 2026 20:45
trungtai1805 pushed a commit to trungtai1805/warp that referenced this pull request May 9, 2026
## Summary
We shouldn't show the plugin installation chip on Oz runs (doesn't make
sense to install the plugin over a shared session or in an ambient agent
run).

## Tests
<img width="1160" height="1385" alt="image"
src="https://github.com/user-attachments/assets/2b1756ae-50a5-4b9c-a43b-25d5e47efd83"
/>


_This PR was created by [Oz](https://warp.dev/oz) (running Codex)._

Co-authored-by: Oz <oz-agent@warp.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants