[QUALITY-598] Exclude child agent initial prompt from history completions#10304
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds a flat child-conversation index and uses it to filter child-agent conversation prompts out of AI prompt history across live, cleared, and persisted sources.
Concerns
- Manual testing is required for changes that can be manually tested. Please include screenshots or a screen recording that show the prompt completion history excluding child agent prompts while preserving regular user prompts, or justify why visual evidence is not possible.
Verdict
Found: 0 critical, 1 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
liliwilson
approved these changes
May 7, 2026
cephalonaut
changed the title
cephalonaut
force-pushed
the
matthew/child-visibility
branch
from
38b5434 to
ae599e4
Compare
cephalonaut
changed the title
Contributor
Author
|
Hey Lili - realized previous approach was too broad. I really just want to skip first exchange of child conversations so that the initial child agent prompt is not included. |
cephalonaut
force-pushed
the
matthew/child-visibility
branch
from
ae599e4 to
cfe7375
Compare
Skip the synthetic orchestrator prompt in child agent conversations by using .skip(1) on root_task_exchanges() when the conversation is a child. This preserves user follow-up queries while requiring no persistence changes — is_child_agent_conversation() is derived from parent_conversation_id/parent_agent_id which are already persisted. Also clears children_by_parent in reset() for consistency. Closes QUALITY-598 Co-Authored-By: Oz <oz-agent@warp.dev>
cephalonaut
force-pushed
the
matthew/child-visibility
branch
from
cfe7375 to
2fccbd9
Compare
liliwilson
approved these changes
May 7, 2026
Contributor
liliwilson
left a comment
liliwilson
left a comment
There was a problem hiding this comment.
Nice, this makes sense to me!
trungtai1805
pushed a commit
to trungtai1805/warp
that referenced
this pull request
May 9, 2026
…ions (warpdotdev#10304) ## Description Skip the synthetic orchestrator prompt in child agent conversations by using `.skip(1)` on `root_task_exchanges()` when the conversation is a child (`is_child_agent_conversation()`). User follow-up queries in the same child conversation are preserved. This approach requires no persistence changes — `is_child_agent_conversation()` is derived from `parent_conversation_id`/`parent_agent_id` which are already persisted in `AgentConversationData`. It works correctly across app restarts and server-restored conversations. Also clears `children_by_parent` in `reset()` for consistency (pre-existing omission). ## Linked Issue - [QUALITY-598](https://linear.app/warpdotdev/issue/QUALITY-598/exclude-child-agent-prompts-from-history-completions) ## Testing Manual: ran orchestration spawning child agents, verified the orchestrator's initial prompt no longer appears in agent input completions while user follow-up queries in revealed child panes still appear. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode --- [Conversation](https://staging.warp.dev/conversation/1cd70e6d-e2d8-44a1-86fd-33a12fdd585c) | [Plan](https://staging.warp.dev/drive/notebook/RatsJ03TieFO8Ax5hxso9b) CHANGELOG-BUG-FIX: Child agent initial prompts (from orchestrator) no longer appear in the agent input completion history. Co-authored-by: Oz <oz-agent@warp.dev>
tungd
pushed a commit
to tungd/warp
that referenced
this pull request
May 11, 2026
…ions (warpdotdev#10304) ## Description Skip the synthetic orchestrator prompt in child agent conversations by using `.skip(1)` on `root_task_exchanges()` when the conversation is a child (`is_child_agent_conversation()`). User follow-up queries in the same child conversation are preserved. This approach requires no persistence changes — `is_child_agent_conversation()` is derived from `parent_conversation_id`/`parent_agent_id` which are already persisted in `AgentConversationData`. It works correctly across app restarts and server-restored conversations. Also clears `children_by_parent` in `reset()` for consistency (pre-existing omission). ## Linked Issue - [QUALITY-598](https://linear.app/warpdotdev/issue/QUALITY-598/exclude-child-agent-prompts-from-history-completions) ## Testing Manual: ran orchestration spawning child agents, verified the orchestrator's initial prompt no longer appears in agent input completions while user follow-up queries in revealed child panes still appear. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode --- [Conversation](https://staging.warp.dev/conversation/1cd70e6d-e2d8-44a1-86fd-33a12fdd585c) | [Plan](https://staging.warp.dev/drive/notebook/RatsJ03TieFO8Ax5hxso9b) CHANGELOG-BUG-FIX: Child agent initial prompts (from orchestrator) no longer appear in the agent input completion history. Co-authored-by: Oz <oz-agent@warp.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Skip the synthetic orchestrator prompt in child agent conversations by using
.skip(1)onroot_task_exchanges()when the conversation is a child (is_child_agent_conversation()). User follow-up queries in the same child conversation are preserved.This approach requires no persistence changes —
is_child_agent_conversation()is derived fromparent_conversation_id/parent_agent_idwhich are already persisted inAgentConversationData. It works correctly across app restarts and server-restored conversations.Also clears
children_by_parentinreset()for consistency (pre-existing omission).Linked Issue
Testing
Manual: ran orchestration spawning child agents, verified the orchestrator's initial prompt no longer appears in agent input completions while user follow-up queries in revealed child panes still appear.
Agent Mode
Conversation | Plan
CHANGELOG-BUG-FIX: Child agent initial prompts (from orchestrator) no longer appear in the agent input completion history.